Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Positioning broken after upgrade 3.0.10 -> 3.0.13 #142

Closed
mir3z opened this issue Jul 19, 2016 · 5 comments
Closed

Positioning broken after upgrade 3.0.10 -> 3.0.13 #142

mir3z opened this issue Jul 19, 2016 · 5 comments

Comments

@mir3z
Copy link

mir3z commented Jul 19, 2016

After I upgraded the library to 3.0.13 I noticed tooltip is no longer pointing to desired place. It has some kind of constant position shift.

Looking at the release notes I guess that

Add support to those elements whose parent elements or itself has been applied with transform

is responsible for that. I use react-list and it uses CSS transform: translate property to scroll a list. Each item of the list contains some elements that have tooltip attached. When I disable transform property in object inspector the list becomes broken but tooltip is displayed correctly.

@wwayne
Copy link
Collaborator

wwayne commented Jul 19, 2016

Actually I did some slight modification on constant position shift for showing the tooltip more nicely... I don't know how much does you mean some kind of constant position shift.

If it is not too much, you can use offset to modify it, but if it appears in a totally wrong place, I need to take a look

@mir3z
Copy link
Author

mir3z commented Jul 21, 2016

I mean It's completely broken and the bottom line is that react-tooltip does not work with react-list.

@maullerz
Copy link

I am used react-tooltip in my app in many part and confirm - position of tooltip completely broken.
I was need to edit asap markup for tooltip in each part of app, mostly like
position: relative/absolute
margin-top: 30-40px

wwayne added a commit that referenced this issue Jul 27, 2016
@wwayne
Copy link
Collaborator

wwayne commented Jul 27, 2016

I add a new attribute countTransform whose default value is true. For your case, you should set it to false so that react-tooltip won't count react-list's transform into calculation.

You can use this attribute since 3.1.0

@wwayne wwayne closed this as completed Jul 27, 2016
@maullerz
Copy link

Great thanks! It works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants