Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move onItemEnter/onItemLeave listeners onto the items. #206

Closed
wants to merge 4 commits into from
Closed

Move onItemEnter/onItemLeave listeners onto the items. #206

wants to merge 4 commits into from

Conversation

marklawlor
Copy link
Contributor

Proposed Change:

Move onItemEnter/onItemLeave listeners onto the items.

Add onRowEnter/onRowLeave props

Fixes: #205 205

Change type

  • Bugfix
  • New feature

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@marklawlor
Copy link
Contributor Author

I'm confused why the existing code toggles this.selecting on hover events. I would assume that you wouldn't want these calbacks to fire when selecting. I keep it as it, but it seems incorrect. Can someone please clarify the reasoning.

@marklawlor marklawlor mentioned this pull request Jan 21, 2021
Closed
5 tasks
@marklawlor marklawlor closed this Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onItemHover / onItemLeave is applied only to rows - not items
1 participant
@marklawlor