Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Google Photos): Add Spoof features patch #3459

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

oSumAtrIX
Copy link
Member

@oSumAtrIX oSumAtrIX commented Jul 20, 2024

@Pamilg8
Copy link

Pamilg8 commented Jul 20, 2024

How can this be possible?

@oSumAtrIX
Copy link
Member Author

Refer to https://support.google.com/photos/answer/10100180?hl=en

@cyberboh
Copy link

Google Photos is the one of pre-installed Google Apps in most Android nowadays. How can this possible to install over pre-installed version?

@oSumAtrIX
Copy link
Member Author

Refer to https://github.com/ReVanced/revanced-patches/blob/dev/src/main/kotlin/app/revanced/patches/googlephotos/misc/gms/GmsCoreSupportPatch.kt

@cyberboh
Copy link

Refer to https://github.com/ReVanced/revanced-patches/blob/dev/src/main/kotlin/app/revanced/patches/googlephotos/misc/gms/GmsCoreSupportPatch.kt

But original pkg name is not changed what i'm seeing in the patches. So, patched version will not be installed

@oSumAtrIX
Copy link
Member Author

The package name is changed: https://github.com/ReVanced/revanced-patches/blob/dev/src/main/kotlin/app/revanced/patches/googlephotos/misc/gms/GmsCoreSupportPatch.kt#L13

@sotakoira
Copy link

Currently the patch is spoofing Pixel 5 (unlimited storage saver), wouldn't it be better to change it to Pixel 1 (unlimited original quality)? Eventually with a toggle somewhere

@n1cKz1
Copy link

n1cKz1 commented Jul 23, 2024

A toggle sounds impractical for this, maybe as a patch option instead. Though I don't see why someone would choose compressed quality over original

@oSumAtrIX
Copy link
Member Author

No option or toggle is necessary

@trmdi
Copy link

trmdi commented Aug 7, 2024

There would be a lot of users using this patch and taking a lot of TBs from Google, that could make Google angry and make more effort in taking down Revanced. Do you think this patch should be done?

@cyberboh
Copy link

cyberboh commented Aug 7, 2024

There would be a lot of users using this patch and taking a lot of TBs from Google, that could make Google angry and make more effort in taking down Revanced. Do you think this patch should be done?

I don't think so, see most of custom roms nowadays using unlimited Google photos, like pixel experience one.
But they are still exist, Google mostly ignored this.

@oSumAtrIX
Copy link
Member Author

ReVanced is open source. Taking it down would mean getting rid of any trace so no. The correct way would be to protect the app from modifications

@n1cKz1
Copy link

n1cKz1 commented Aug 7, 2024

This patch also doesn't circumvent any "paid features" as you can't pay for unlimited storage. If you look at history Google prefers breaking such patches by securing their apps rather than taking the legal route, especially against open-source repositories. (such as Pixelify which also spoofs Pixel in pretty much everything Google and has been broken quite a few times by updates before)

@steel101

This comment was marked as spam.

@pablomentabo
Copy link

This patch also doesn't circumvent any "paid features" as you can't pay for unlimited storage.

On T-Mobile you can

@Eula13
Copy link

Eula13 commented Aug 10, 2024

There would be a lot of users using this patch and taking a lot of TBs from Google, that could make Google angry and make more effort in taking down Revanced. Do you think this patch should be done?

I don't think so, see most of custom roms nowadays using unlimited Google photos, like pixel experience one. But they are still exist, Google mostly ignored this.

At least it requires major tinkering to be possible (unlocking bootloader, rooting, and/or installing a custom rom) which only a few people do, but now providing it to non-rooted users as simple as patching it via Revanced may provoke Google

@n1cKz1
Copy link

n1cKz1 commented Aug 10, 2024

On T-Mobile you can

That's a completely different thing. Also T-Mobile isn't available everywhere so it's not like everyone has the choice to get unlimited storage via that.

@pablomentabo
Copy link

On T-Mobile you can

That's a completely different thing. Also T-Mobile isn't available everywhere so it's not like everyone has the choice to get unlimited storage via that.

Completely understandable, though I wasn't implying it's available to everyone, but it is an option for some

@ReVanced ReVanced locked as off-topic and limited conversation to collaborators Aug 10, 2024
@oSumAtrIX oSumAtrIX linked an issue Aug 13, 2024 that may be closed by this pull request
3 tasks
@oSumAtrIX oSumAtrIX force-pushed the feat/photos-unlimited-upload branch 2 times, most recently from 57b6dde to 88a82c8 Compare August 14, 2024 22:04
@oSumAtrIX oSumAtrIX changed the title feat(Google Photos): Add Enable unlimited storage patch feat(Google Photos): Add Spoof features patch Aug 14, 2024
@oSumAtrIX oSumAtrIX marked this pull request as ready for review August 14, 2024 22:04
@ReVanced ReVanced unlocked this conversation Aug 14, 2024
@oSumAtrIX oSumAtrIX force-pushed the feat/photos-unlimited-upload branch from 88a82c8 to cfe844e Compare August 14, 2024 22:32
@steel101
Copy link

Is it possible to test this patch before it goes live I have 12 different android phones I could try it on

@oSumAtrIX
Copy link
Member Author

It's open source, so yes. For support, move to one of our links at https://revanced.app.

@oSumAtrIX oSumAtrIX merged commit 7c218cd into dev Aug 15, 2024
2 checks passed
revanced-bot pushed a commit that referenced this pull request Aug 15, 2024
# [4.13.0-dev.1](v4.12.1-dev.1...v4.13.0-dev.1) (2024-08-15)

### Features

* **Google Photos:** Add `Spoof features` patch ([#3459](#3459)) ([7c218cd](7c218cd))
* **SCB Easy:** Remove broken `Remove debugging detection` patch ([#3518](#3518)) ([f4e23cb](f4e23cb))
@cyberboh
Copy link

I get this warning, does these as expected or error need to be resolved?

WARNING: Could not set option value for the Spoof features patch: Type [Ljava.lang.String; was expected but received type java.util.ArrayList
WARNING: Could not set option value for the Spoof features patch: Type [Ljava.lang.String; was expected but received type java.util.ArrayList

@oSumAtrIX oSumAtrIX deleted the feat/photos-unlimited-upload branch August 15, 2024 07:39
@oSumAtrIX
Copy link
Member Author

This is caused by the options using array types but the deserializer from ReVanced CLI uses list. The DSL branch fixes the issue as now the option types also use List, until then you cant set the options.

@kazimmt
Copy link
Contributor

kazimmt commented Aug 15, 2024

I don't know whether I should create a new issue or not, but the issue is that it requires logging in every time we clear the app from the background (close the app).

@steel101
Copy link

Works just have to login each time I have uploaded over 30gb so far and it has not counted towards my storage amount

revanced-bot pushed a commit that referenced this pull request Aug 15, 2024
# [4.13.0](v4.12.0...v4.13.0) (2024-08-15)

### Bug Fixes

* **YouTube - GmsCore support:** Fix notifications not working by using the correct permissions ([19ddae2](19ddae2))

### Features

* **Google Photos:** Add `Spoof features` patch ([#3459](#3459)) ([7c218cd](7c218cd))
* **SCB Easy:** Remove broken `Remove debugging detection` patch ([#3518](#3518)) ([f4e23cb](f4e23cb))
* **YouTube:** Add `Check watch history domain name resolution` patch ([#3537](#3537)) ([2af1425](2af1425))
@SaleOff
Copy link

SaleOff commented Aug 15, 2024

I don't know whether I should create a new issue or not, but the issue is that it requires logging in every time we clear the app from the background (close the app).

that true :((

@steel101
Copy link

One more thing is the app has to stay open for it to back up stops uploading when I'm background

@Jman-Github
Copy link

I also noticed that the map feature to change the location of a photo does not work.
Vesktop_08-15-2024_2a3fd201-0983-4a06-9dfb-14e6bed94a61

@Subbarao6338
Copy link

Currently app is not working, not uploading any photos,

@steel101
Copy link

Upload is working is stopped last night for about 15 mins might have been Google services

@steel101
Copy link

Screenshot_20240816-093531_Photos.png

Is the photos meta data going to get this app caught because it says taken on moto phone not pixel

@eugenio412
Copy link

Screenshot_20240816-093531_Photos.png

Is the photos meta data going to get this app caught because it says taken on moto phone not pixel

No, it's the same in all the custom rom as well, Google never complained

@Jman-Github
Copy link

Jman-Github commented Aug 16, 2024

You could try using the Spoof build info universal patch and see if that does anything. I doubt it matters though as per the previous reply.

@directentis1
Copy link

Is the photos meta data going to get this app caught because it says taken on moto phone not pixel

Non.. it'll spoof your account as Pixel only, not by your photos or its metadata.
I've moved some movies from somewhere to my storage and force it to upload to Photos via this glitch.
And they work as normal.

@steel101
Copy link

Any way to get maps working

@pathanac
Copy link

20240825_002917
Oh, it backups original quality? I thought high resolution saver. Btw, the pixel model either 1 or 5, are they still on market? I think it is quite old model and probably hardware might be broken and no one using if it is not any new sell. Will google detect using this patch? e.g. if the model is not available for sell anymore.

@oSumAtrIX
Copy link
Member Author

oSumAtrIX commented Aug 24, 2024

Yes, the patch is very likely evident server side. Everything beyond that is speculation

@pathanac
Copy link

Yes, the patch is very likely evident server side. Everything beyond that is speculation

How safe do you think?
My concern is Google might be able to detect this new backup weird if pixel device suppose to be gone for years. Btw, pixel is not selling in my country so not sure we still have actual device in market.

@oSumAtrIX
Copy link
Member Author

According to the TOS a clear violation of the terms. Using the patch is therefore putting your account at risk as described in the TOS. I can't really claim more than that.

@teekamsuthar
Copy link

When I used an old Photos APK - it asks me to login using Google account but then I get a message this account already exists on this phone. Why am I not able to use existing account?

Should I use a disposable account to backup photos? So my primary account doesn't get banned/deleted by Google in case they detect TOS violation in the future??

P.S. Thanks for the patch! :)

@oSumAtrIX
Copy link
Member Author

For support, move to one of our links at https://revanced.app.

@toastmod

This comment was marked as off-topic.

@LisoUseInAIKyrios

This comment was marked as off-topic.

iamguptanitesh

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Google Photos): Add Google Pixel Phone patch