feat(Messenger): Add Hide inbox subtabs patch
#3163
Conversation
oSumAtrIX
changed the title
Hide inbox subtabs patchHide inbox subtabs patch
|
|
||
| @Patch( | ||
| name = "Hide inbox subtabs", | ||
| compatiblePackages = [CompatiblePackage("com.facebook.orca")], |
There was a problem hiding this comment.
please add a description that explains what the patch does. The name isn't sufficient to understand.
| import com.android.tools.smali.dexlib2.AccessFlags | ||
| import com.android.tools.smali.dexlib2.Opcode | ||
|
|
||
| internal object InboxSubTabsItemSupplierFingerprint : MethodFingerprint( |
There was a problem hiding this comment.
Perhaps a better name can be chosen? It is unclear what this fingerprint resolves to.
There was a problem hiding this comment.
Supplies items for subtabs? Anyway, I will make it CreateInboxSubTabs
|
|
||
| @Patch( | ||
| name = "Hide inbox subtabs", | ||
| compatiblePackages = [CompatiblePackage("com.facebook.orca")], |
There was a problem hiding this comment.
The patch relies on a complex fingeprint, perhaps it will break with future versions which is why you should either consider simplifying the fingerprint or constrain the patch to some version.
There was a problem hiding this comment.
These subtabs have been added during 430 versions, and fingerprint resolves to an obfuscated class that works on a Runnable, unfortunately it's quite fragile print and breaks easily. I have to find more solid way to target this.
I don't understand what this means. Your screenshot shows a red box around nothing. |
There are two tabs, |
seaque
force-pushed
the
feat/messenger-subtabs
branch
from
08b0107 to
39bf879
Compare
|
Accidentally force pushed on your refactor, I need to test the fingerprint in multiple versions, some patched versions tend to be false positives. |
|
Tested new fingerprint on:
and it seems to be working. |
This breaks API but since its a fix thats fine
|
Thank you for contributing to ReVanced. Join us on Discord to receive a role for your contribution. |
# [4.9.0-dev.4](v4.9.0-dev.3...v4.9.0-dev.4) (2024-06-01) ### Features * **Messenger:** Add `Hide inbox subtabs` patch ([#3163](#3163)) ([24e4ebd](24e4ebd))
# [4.9.0](v4.8.3...v4.9.0) (2024-06-02) ### Bug Fixes * **YouTube - Spoof client:** Allow swipe gestures to enter/exit fullscreen when spoofing with `Android VR` client ([#3259](#3259)) ([5114900](5114900)) * **YouTube - Spoof client:** Restore playback speed menu when spoofing to an iOS client ([95f290f](95f290f)) ### Features * **Messenger:** Add `Hide inbox subtabs` patch ([#3163](#3163)) ([24e4ebd](24e4ebd)) * **YouTube - Hide layout components:** Disable like / subscribe button glow animation ([#3265](#3265)) ([68d35ea](68d35ea)) * **YouTube - Playback speed:** Add option to show speed dialog button in video player ([#3197](#3197)) ([ad00305](ad00305)) * **YouTube Music:** Support version `7.03` ([#3272](#3272)) ([d1ceca3](d1ceca3)) * **YouTube:** Support version `19.12`, `19.13`, `19.14`, `19.15` and `19.16` ([#3239](#3239)) ([99b07e0](99b07e0))
# [4.9.0](v4.8.3...v4.9.0) (2024-06-02) ### Bug Fixes * **YouTube - Spoof client:** Allow swipe gestures to enter/exit fullscreen when spoofing with `Android VR` client ([ReVanced#3259](https://github.com/E85Addict/revanced-patches/issues/3259)) ([5114900](5114900)) * **YouTube - Spoof client:** Restore playback speed menu when spoofing to an iOS client ([95f290f](95f290f)) ### Features * **Messenger:** Add `Hide inbox subtabs` patch ([ReVanced#3163](https://github.com/E85Addict/revanced-patches/issues/3163)) ([24e4ebd](24e4ebd)) * **YouTube - Hide layout components:** Disable like / subscribe button glow animation ([ReVanced#3265](https://github.com/E85Addict/revanced-patches/issues/3265)) ([68d35ea](68d35ea)) * **YouTube - Playback speed:** Add option to show speed dialog button in video player ([ReVanced#3197](https://github.com/E85Addict/revanced-patches/issues/3197)) ([ad00305](ad00305)) * **YouTube Music:** Support version `7.03` ([ReVanced#3272](https://github.com/E85Addict/revanced-patches/issues/3272)) ([d1ceca3](d1ceca3)) * **YouTube:** Support version `19.12`, `19.13`, `19.14`, `19.15` and `19.16` ([ReVanced#3239](https://github.com/E85Addict/revanced-patches/issues/3239)) ([99b07e0](99b07e0)) ### Performance Improvements * Personal Logo && Add upstream sync ([e9d6554](e9d6554))
This patch removes Home / Channels tabs between active now tray and chat boxes.
I also changed the directory of
Hide inbox adspatch from patches/messenger/ads/inbox to patches/messenger/inbox/ads due to: