Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Mi Fitness - Fix login): Patch correct register #2942

Merged
merged 14 commits into from
Mar 30, 2024
Merged

fix(Mi Fitness - Fix login): Patch correct register #2942

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e0efcd3
init
pisek Feb 15, 2024
c5a0b2d
fix
pisek Feb 15, 2024
2971170
api fix
pisek Feb 15, 2024
70ccd3d
refactor
oSumAtrIX Feb 16, 2024
da07c67
only force english
oSumAtrIX Feb 16, 2024
15142ab
naming
pisek Feb 19, 2024
966a728
naming fixes
pisek Feb 19, 2024
af83a74
naming fixes
pisek Feb 19, 2024
d0da84a
correct descriptioon
oSumAtrIX Feb 21, 2024
6a2545e
change of approach - resolving param id from instruction
pisek Mar 20, 2024
9ca5c30
refactor
oSumAtrIX Mar 25, 2024
ae50c92
Merge pull request #2 from ReVanced/dev
pisek Mar 28, 2024
cc239e0
back to orginal approach - seems that the idea with registers does no…
pisek Mar 28, 2024
caf7275
reg fix
pisek Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions src/main/kotlin/app/revanced/patches/mifitness/misc/login/FixLoginPatch.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,11 @@ package app.revanced.patches.mifitness.misc.login

import app.revanced.patcher.data.BytecodeContext
import app.revanced.patcher.extensions.InstructionExtensions.addInstruction
import app.revanced.patcher.extensions.InstructionExtensions.getInstruction
import app.revanced.patcher.patch.BytecodePatch
import app.revanced.patcher.patch.annotation.CompatiblePackage
import app.revanced.patcher.patch.annotation.Patch
import app.revanced.patches.mifitness.misc.login.fingerprints.XiaomiAccountManagerConstructorFingerprint
import app.revanced.util.exception
import com.android.tools.smali.dexlib2.iface.instruction.OneRegisterInstruction

@Patch(
name = "Fix login",
Expand All @@ -20,16 +18,9 @@ object FixLoginPatch : BytecodePatch(
setOf(XiaomiAccountManagerConstructorFingerprint),
) {
override fun execute(context: BytecodeContext) {
XiaomiAccountManagerConstructorFingerprint.result?.let {
it.mutableMethod.apply {
val isCertifiedIndex = it.scanResult.patternScanResult!!.startIndex
val isCertifiedRegister = getInstruction<OneRegisterInstruction>(isCertifiedIndex).registerA

addInstruction(
isCertifiedIndex,
"const/4 p$isCertifiedRegister, 0x0",
)
}
} ?: throw XiaomiAccountManagerConstructorFingerprint.exception
XiaomiAccountManagerConstructorFingerprint.result?.mutableMethod?.addInstruction(
0,
"const/4 p2, 0x0",
LisoUseInAIKyrios marked this conversation as resolved.
Show resolved Hide resolved
) ?: throw XiaomiAccountManagerConstructorFingerprint.exception
}
}
6 changes: 4 additions & 2 deletions ...d/patches/mifitness/misc/login/fingerprints/XiaomiAccountManagerConstructorFingerprint.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,14 @@ package app.revanced.patches.mifitness.misc.login.fingerprints
import app.revanced.patcher.extensions.or
import app.revanced.patcher.fingerprint.MethodFingerprint
import com.android.tools.smali.dexlib2.AccessFlags
import com.android.tools.smali.dexlib2.Opcode

internal object XiaomiAccountManagerConstructorFingerprint : MethodFingerprint(
accessFlags = AccessFlags.PRIVATE or AccessFlags.CONSTRUCTOR,
customFingerprint = { methodDef, _ ->
methodDef.definingClass == "Lcom/xiaomi/passport/accountmanager/XiaomiAccountManager;"
},
opcodes = listOf(Opcode.IF_NEZ),
parameters = listOf(
"Landroid/content/Context;",
"Z",
),
)
Loading