Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Force app into landscape-only mode #544

Closed
3 tasks done
Green-de-la-Bean opened this issue Jul 30, 2023 · 9 comments
Closed
3 tasks done

feat: Force app into landscape-only mode #544

Green-de-la-Bean opened this issue Jul 30, 2023 · 9 comments
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@Green-de-la-Bean
Copy link

Application

YouTube

Issue

Unlike all other video players, on the YouTube app when on an Android tablet, if you open a video in full screen and then rotate the device to a vertical orientation, it will change the video to be shown in that orientation. This makes watching a video in bed very annoying as you constantly have to adjust the rotation lock.

Patch

Have the app run in a mode similar to many Android games where it will only display in landscape mode at all times. I believe this would be fairly simple to add as you could just add the line: android:screenOrientation="landscape" to the manifest.

Motivation

I personally would benefit from this because I hate having to constantly change the rotation settings. I don't think it would take very long to add and would probably benefit other users of YouTube ReVanced who have it installed on a tablet device.

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@Green-de-la-Bean Green-de-la-Bean added the Feature request Requesting a new feature that's not implemented yet label Jul 30, 2023
@NBruderman

This comment was marked as spam.

@oSumAtrIX
Copy link
Member

Not sure why you would "constantly change the rotation settings." You can also automate it with something like Tasker.

@Green-de-la-Bean
Copy link
Author

I don't think telling me to get some paid app is a good solution.

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Jul 30, 2023

Why not? I gave an example. we'd have to pay time to implement this

@Green-de-la-Bean
Copy link
Author

Because for other people's sake, unless they go out of their way to ask this, then they'll be stuck with an annoying interface on tablet mode. The reason you have to fiddle with rotation lock settings is because if you try to use Youtube holding the tablet in an orientation where your viewing the screen not relative to the ground (lying down for instance) then the tablet will display the video incorrectly. This means if you want to view a video in landscape but then use other apps in portrait you have to lock the screen every time you move between apps. In the short time this issue has been open, someone else has already agreed with my point of view.
I'd do it myself but I don't think ReVanced manager lets me edit the android manifest file at all.

@LisoUseInAIKyrios
Copy link
Contributor

I'd do it myself but I don't think ReVanced manager lets me edit the android manifest file at all.

If you want to do it, then make a new ReVanced patch and create a GitHub pull request for the change.

It can be a universal "change to landscape orientation" patch that can be applied to any app.

@oSumAtrIX
Copy link
Member

@Green-de-la-Bean The lock rotation setting on Android does this already, as explained; you can automate it using Tasker as an example

@nl255
Copy link

nl255 commented Jul 31, 2023

@Green-de-la-Bean The lock rotation setting on Android does this already, as explained; you can automate it using Tasker as an example

Some apps, such as Freezer, ignore that setting and will auto-rotate no matter what you do.

@Fred-Vatin
Copy link

Fred-Vatin commented Aug 15, 2023

There was no issue with former vanced in full screen on tablet when auto rotate was OFF. It is expected that revanced behaves the same. Yes there are some third apps that can automate the screen orientation for specific app. But it's not the same as a built-in feature allowing to use revanced in portrait and only switch to landscape when full screen.

Why this issue is closed and marked completed instead of not planned? It's misleading.

Requested many times like in ReVanced/revanced-patches-template#1840 ReVanced/revanced-patches-template#1052. ReVanced/revanced-patches-template#985 describes perfectly the issue and motivation. Currently you can not lock video in landscape unless using a third party app or playing with the QS multiple time to achieve what you want every time.

This feature keeps being asked for a reason. The problem seems to be YouTube itself. Official app 18.31.37 has the same issue. Full screen sticks in portrait if auto rotate is OFF. But if a patch can solve this to only use landscape sensor to force any landscape mode in full screen, it would be perfect.

@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@revanced-bot revanced-bot transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
oSumAtrIX added a commit that referenced this issue Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

6 participants