feat(YouTube - Downloads): Pause video when external download button is clicked

[HeroGalak]

Application

YouTube

Issue

When using a different app from NewPipe such as Seal or YTDLnis to download videos directly from YTRevanced, clicking the external download button while video is playing make the player go in PiP mode and the prompt of the custom downloader is showed under the minimized player of YT.

Prompt after clicking the external download button if video is playing (using YTDLnis)

Patch

The external downloads patch should be modified to allow stopping the player automatically when button is clicked. In this way the downloader prompt is correctly shown.

Prompt after clicking the external download button if playback is stopped (using YTDLnis)

Motivation

In this way the user experience is better and fluent

Acknowledgements

• I have searched the existing issues and this is a new and no duplicate or related to another open issue.
• I have written a short but informative title.
• I filled out all of the requested information in this issue properly.

[YT-Advanced]

I also faced this problem too. Hope Revanced Team can do a fix

[RamPawar7]

I had a similar issue where the player would switch to PiP whenever I turned on Wi-Fi and the Wi-Fi networks card appeared. Thank you, now I know that pausing the video prevents this issue. I made an Automate flow to auto pause the video whenever Wi-Fi is turned on.

[oSumAtrIX]

Does the same happen when you click it in the share menu?

[YT-Advanced]

Does the same happen when you click it in the share menu?

The video continue playing but it is not change to PiP mode

[LisoUseInAIKyrios]

I'm sure you know, but the pip box can be dragged around on screen, so it can be moved out of the way to use the downloader.

Maybe just before the external downloader is launched, the ReVanced pip override could be temporarily turned off for the next few seconds. Video playback would completely stop playing, and no pip would show up.

[YT-Advanced]

I'm sure you know, but the pip box can be dragged around on screen, so it can be moved out of the way to use the downloader.

Maybe just before the external downloader is launched, the ReVanced pip override could be temporarily turned off for the next few seconds. Video playback would completely stop playing, and no pip would show up.

It can easily solved by pause the video. I think you can do it by trigger OnClick() method

[LisoUseInAIKyrios]

I tried adding a temporary false override to the pip feature, where if the external downloader was opened it would temporarily turn off the pip enable patch hook for 5 seconds.

And it seems to work...most of the time. Usually the video stops playing when launching the downloader, but sometimes it keeps playing anyways like it has a mind of its own (possibly because it's using a cached value of the hooked pip function, so temporary turning it off gives inconsistent behavior).

An alternative solution that works right now, is use NewPipe. It uses an overlay to start the download and thus it never opens a new full screen app and the video keeps playing under the overlay without UI issues.

[oSumAtrIX]

It indeed depends on the app. Although, I am wondering why the download button action behaves differently to that of the share menu item, when they both should be the same.

[RamPawar7]

Share button does trigger PiP, but only the first time after opening the app when it's been closed for a few minutes. At least for me it happens like this.
https://github.com/ReVanced/revanced-patches/assets/96973076/bd6bcac4-1033-40a7-a7ea-8f16788600be

[oSumAtrIX]

So how is it different from the download button

[Covkie]

This seems to be a larger issue with PiP in general - Using the share menu caused the playing video to enter PiP(Not 100% of the time) as well as Nearby Share and the External Downloaded popup menu. With Nearby Share this breaks the back button and sends to the home screen.

Overall this breaks user expirence and I would love to see a patch for this.