Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube): Settings menus layout is broken on Android 15 #3976

Closed
3 tasks done
Wojtaz0w opened this issue Nov 24, 2024 · 11 comments · Fixed by #3999
Closed
3 tasks done

bug(YouTube): Settings menus layout is broken on Android 15 #3976

Wojtaz0w opened this issue Nov 24, 2024 · 11 comments · Fixed by #3999
Labels
Bug report Something isn't working

Comments

@Wojtaz0w
Copy link

Wojtaz0w commented Nov 24, 2024

Bug description

Hello. I patched YouTube 19.45.38 with ReVanced patches 5.1.0 and the layout inside of ReVanced settings categories is broken; they are partially underneath the status bar on my Pixel 9, which makes some toggles impossible/ very hard to tap
Image
Image

Error logs

Solution

Additional context

Return YT Dislike and Sponsor lock settings are not affected, most likely they are coded in different way..? I'm not sure, I ain't no coder, they do have an animation when opening and the rest of settings don't

Acknowledgements

  • I have checked all open and closed bug reports and this is not a duplicate.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@Wojtaz0w Wojtaz0w added the Bug report Something isn't working label Nov 24, 2024
@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Nov 24, 2024

Try turning off recommended version checks in Manager and try patching 19.46.40 (it should patch successful), and see if the issue is fixed.

If it's not, then uninstall patched YT and try patching 19.43.41 (a supported version).

Report back if either of these fix it.

@Wojtaz0w
Copy link
Author

The bug is still present on version 19.46.40
Screenshot_20241126-053102.png

The bug doesn't occur in version 19.43.41
Screenshot_20241126-054638.png

@LisoUseInAIKyrios
Copy link
Contributor

For now keep patching 19.43 until a fix can be figured out.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug: Layout for YT ReVanced settings is broken on Android 15 bug(YouTube): Settings menus layout is broken on Android 15 Nov 26, 2024
@cyberboh
Copy link

@Wojtaz0w Try patching 19.45.38 using patches vers. 5.0.2, you can use ReVanced CLI as of now because ReVanced manager can not select patches version (it always uses latest patches available)

@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Nov 26, 2024

I don't think any changes in 5.1 could have caused this, but if someone want to try patching the prior version then go ahead.

The problem is likely an incompatibility of YT 19.45 and the way the ReVanced settings menu is loaded.

I think fixing #388 will also fix this issue.
Fixing the navigation bar back button does not fix this issue.

@cyberboh
Copy link

@LisoUseInAIKyrios From this comment #3989 (comment) it could be patches issue, he downgraded the patches version and the issue gone.

@LisoUseInAIKyrios
Copy link
Contributor

That comment is for a different bug and is fixed with https://www.github.com/ReVanced/revanced-patches/pull/3990

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Nov 26, 2024

I remember someone mentioning that the issue is happening on the YouTube app and not just the settings. They mentioned an Android setting to toggle which would fix the issue but I don't remember which one. In any case, if it's caused by a patch, the one who downgraded should identify which exact version introduces the bug

@aliernfrog

This comment has been minimized.

@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Nov 26, 2024

The issue can be reproduced using the Android emulator with a new Pixel device image running Android 15.

For pixel devices the transparent navigation bar setting is not on by default, and turning it off does not fix or change the bug behavior.

@aliernfrog
Copy link
Contributor

aliernfrog commented Nov 26, 2024

This only occurs when "Transparent navigation bar" toggle in developer options is enabled. This toggle is disabled by default for me.

Nevermind, I can now reproduce the issue even when the toggle is disabled. Not sure if something affected the issue or I just didn't test it carefully when writing the comment (the issue is not as visible on my end).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
5 participants