-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More accurate preview from sponsorblock by changing playback speed #2112
Comments
SponsorBlock already included a UI to go frame by frame. In combination with a slow playback speed why does this not suffice? |
Sorry for late reply. While the frame by frame is more than enough for cutting visual change, when it comes to cut audio or speech, even at 0.75x playback speed is not enough. Although the preview from sponsorblock when the video played at 0.75x is close to accurate it is still difficult to cut speech or audio precisely. Often times, after submitting the segment you have to check through browser such as Kiwi browser or Firefox to make sure whether the segment is good or not. So by having more accurate preview it will help tremendously to cut audio or speech more precisely resulting in higher quality segments and easier process for the contributors when doing submission on mobile phone. |
Implemented in commit b1e423d. Available patch options: ['custom-playback-speed']
granularity = "11"
min = "0.25"
max = "5.0" |
Thank you for implementing this feature 👍 |
# [2.174.0-dev.17](ReVanced/revanced-patches@v2.174.0-dev.16...v2.174.0-dev.17) (2023-05-09) ### Bug Fixes * **youtube/remember-video-quality:** fix default video quality/speed being applied when resuming app. ([ReVanced#2112](ReVanced/revanced-patches#2112)) ([f68a41c](ReVanced/revanced-patches@6643997))
# [2.174.0](ReVanced/revanced-patches@v2.173.0...v2.174.0) (2023-05-24) ### Bug Fixes * account fo breaking changes from ReVanced Patcher ([ReVanced#2103](ReVanced/revanced-patches#2103)) ([5be25cd](ReVanced/revanced-patches@500a619)) * check for opcode type `CONST` ([e5bb63c](ReVanced/revanced-patches@2687b3e)) * incorrect cast of instruction ([fb94a1c](ReVanced/revanced-patches@08f9e63)) * incorrect instruction offsets ([42a5a38](ReVanced/revanced-patches@4263883)) * incorrect smali syntax ([4e74a80](ReVanced/revanced-patches@56bfa33)) * **photomath/unlock-plus:** constrain to last working version ([ReVanced#2232](ReVanced/revanced-patches#2232)) ([4da268e](ReVanced/revanced-patches@03a3b10)) * **readme-generator:** attempt sorting versions with `FlexVer` ([ReVanced#2059](ReVanced/revanced-patches#2059)) ([a54c464](ReVanced/revanced-patches@dd8dcea)) * **spotify/disable-capture-restriction:** make compatible with latest versions ([ReVanced#2095](ReVanced/revanced-patches#2095)) ([e48f127](ReVanced/revanced-patches@7a6a079)) * **twitter:** correctly resolve to integrations methods ([c655416](ReVanced/revanced-patches@8e4ad3e)) * **youtube/custom-video-speed:** add missing class for `video-speeds` patch ([ReVanced#2137](ReVanced/revanced-patches#2137)) ([758ef42](ReVanced/revanced-patches@c35de2b)) * **youtube/integrations:** allow playback of embedded videos ([ReVanced#2092](ReVanced/revanced-patches#2092)) ([8a43d75](ReVanced/revanced-patches@d0671d3)) * **youtube/minimized-playback:** update settings description ([ReVanced#2191](ReVanced/revanced-patches#2191)) ([a561a9a](ReVanced/revanced-patches@3d3c5c2)) * **youtube/remember-video-quality:** fix default video quality/speed being applied when resuming app. ([ReVanced#2112](ReVanced/revanced-patches#2112)) ([f68a41c](ReVanced/revanced-patches@6643997)) * **youtube/return-youtube-dislikes:** fix temporarily frozen video after opening a shorts ([ReVanced#2126](ReVanced/revanced-patches#2126)) ([e0877e3](ReVanced/revanced-patches@d72f2bc)) * **youtube/settings:** fix non functional back button in settings ([ReVanced#2178](ReVanced/revanced-patches#2178)) ([46da834](ReVanced/revanced-patches@97a3a51)) * **youtube/sponsorblock:** fix skip button in wrong location when full screen and comments visible ([ReVanced#2051](ReVanced/revanced-patches#2051)) ([30a954c](ReVanced/revanced-patches@2156a06)) * **youtube/sponsorblock:** fix toast shown when scrubbing thru a paused video ([ReVanced#2152](ReVanced/revanced-patches#2152)) ([c6c23ff](ReVanced/revanced-patches@ff5d719)) * **youtube/spoof-signature-verification:** adjusting summary text ([ReVanced#2169](ReVanced/revanced-patches#2169)) ([4ccb1ee](ReVanced/revanced-patches@dc5af70)) * **youtube/theme:** apply custom seekbar color to video thumbnails ([ReVanced#2085](ReVanced/revanced-patches#2085)) ([d497027](ReVanced/revanced-patches@4635c63)) * **youtube/theme:** move options out of dependency patch ([a953448](ReVanced/revanced-patches@b8ff3ca)) * **youtube/vanced-microg-support:** depend on `client-spoof` patch ([83a4905](ReVanced/revanced-patches@b13feba)) * **youtube/video-speed:** add compatibility annotation ([ReVanced#2156](ReVanced/revanced-patches#2156)) ([ffa2e5d](ReVanced/revanced-patches@e5b7c9d)) * **youtube:** add missing compatibility annotations for `theme` and `hide-load-more-button` ([ReVanced#2150](ReVanced/revanced-patches#2150)) ([78803f8](ReVanced/revanced-patches@9282b54)) ### Features * add capability to filter from protobuf buffer ([b738b6b](ReVanced/revanced-patches@00ca1a0)) * **candylinkvpn:** add `unlock-pro` patch ([ReVanced#2157](ReVanced/revanced-patches#2157)) ([7159f86](ReVanced/revanced-patches@296c485)) * improve structure of `README` ([279b193](ReVanced/revanced-patches@ba4b6d9)) * **messenger:** add `disable-switching-emoji-to-sticker-in-message-input-field` patch ([ReVanced#2099](ReVanced/revanced-patches#2099)) ([ac5532a](ReVanced/revanced-patches@14b30a1)) * **messenger:** add `disable-typing-indicator` patch ([ReVanced#2115](ReVanced/revanced-patches#2115)) ([5d1de4f](ReVanced/revanced-patches@30ae687)) * **patch:** bump compatibility ([ReVanced#2060](ReVanced/revanced-patches#2060)) ([f86836d](ReVanced/revanced-patches@9ab7812)) * **reddit:** add `sanitize-sharing-links` patch ([ReVanced#2192](ReVanced/revanced-patches#2192)) ([9593e4b](ReVanced/revanced-patches@78d112d)) * **reddit:** remove compatibility version constraints ([ReVanced#2226](ReVanced/revanced-patches#2226)) ([f1288e4](ReVanced/revanced-patches@4cf362c)) * **syncforreddit:** add `disable-ads` patch ([ReVanced#2066](ReVanced/revanced-patches#2066)) ([c1de5d6](ReVanced/revanced-patches@148790a)) * **trakt:** add `unlock-pro` patch ([ReVanced#2210](ReVanced/revanced-patches#2210)) ([1e8dcae](ReVanced/revanced-patches@46b35ac)) * **twitch/auto-claim-channel-points:** use correct casing for "Channel Points" ([ReVanced#2138](ReVanced/revanced-patches#2138)) ([76a3bf2](ReVanced/revanced-patches@e27f88b)) * **twitch:** add `auto-claim-channel-points` patch ([ReVanced#2131](ReVanced/revanced-patches#2131)) ([80fb670](ReVanced/revanced-patches@da5a809)) * use consistent names for patches ([6347146](ReVanced/revanced-patches@2d32615)) * **vsco:** add `unlock-pro` patch ([ReVanced#2168](ReVanced/revanced-patches#2168)) ([7ffd1a0](ReVanced/revanced-patches@cd19617)) * **youtube/copy-video-url:** add tap and hold functionality to copy video url buttons ([ReVanced#2174](ReVanced/revanced-patches#2174)) ([95bbf46](ReVanced/revanced-patches@75ba6ba)) * **youtube/downloads:** improve patch description ([e0f6452](ReVanced/revanced-patches@821de81)) * **youtube/hide-filter-bar:** add `PreferenceScreen` summary ([2bba5f7](ReVanced/revanced-patches@a312d8a)) * **youtube/hide-player-overlay:** make it toggleable in settings ([ReVanced#2044](ReVanced/revanced-patches#2044)) ([f693d55](ReVanced/revanced-patches@a042b30)) * **youtube/hide-shorts-components:** hide navigation bar ([24f376a](ReVanced/revanced-patches@686c1f3)) * **youtube/settings:** add reset button to edit preference dialog ([ReVanced#2047](ReVanced/revanced-patches#2047)) ([ede765a](ReVanced/revanced-patches@f269906)) * **youtube/video-speed:** change custom video speeds inside app settings ([ReVanced#2114](ReVanced/revanced-patches#2114)) ([d97815a](ReVanced/revanced-patches@a33e7de)) * **youtube:** `hide-load-more-button` patch ([ReVanced#2078](ReVanced/revanced-patches#2078)) ([7170802](ReVanced/revanced-patches@be98c03)) * **youtube:** add `hide-filter-bar` patch ([6cc5f61](ReVanced/revanced-patches@0932096)) * **youtube:** add `hide-shorts-components` patch ([64868f4](ReVanced/revanced-patches@ca3aae7)) * **youtube:** add options to disable toasts on connection error ([ReVanced#2159](ReVanced/revanced-patches#2159)) ([99916ae](ReVanced/revanced-patches@759c70f)) * **youtube:** constrain patches to `18.16.37` ([758b300](ReVanced/revanced-patches@91e0676)) * **youtube:** import / export of revanced settings ([ReVanced#2077](ReVanced/revanced-patches#2077)) ([b59cb3e](ReVanced/revanced-patches@d209022)) * **youtube:** move video settings to `Video` settings category ([ReVanced#2010](ReVanced/revanced-patches#2010)) ([f4b9180](ReVanced/revanced-patches@1b1abef)) * **youtube:** support version `18.19.35` ([491f292](ReVanced/revanced-patches@c899783))
# [2.174.0](ReVanced/revanced-patches@v2.173.0...v2.174.0) (2023-05-24) ### Bug Fixes * account fo breaking changes from ReVanced Patcher ([ReVanced#2103](ReVanced/revanced-patches#2103)) ([5be25cd](ReVanced/revanced-patches@5be25cd)) * check for opcode type `CONST` ([e5bb63c](ReVanced/revanced-patches@e5bb63c)) * incorrect cast of instruction ([fb94a1c](ReVanced/revanced-patches@fb94a1c)) * incorrect instruction offsets ([42a5a38](ReVanced/revanced-patches@42a5a38)) * incorrect smali syntax ([4e74a80](ReVanced/revanced-patches@4e74a80)) * **photomath/unlock-plus:** constrain to last working version ([ReVanced#2232](ReVanced/revanced-patches#2232)) ([4da268e](ReVanced/revanced-patches@4da268e)) * **readme-generator:** attempt sorting versions with `FlexVer` ([ReVanced#2059](ReVanced/revanced-patches#2059)) ([a54c464](ReVanced/revanced-patches@a54c464)) * **spotify/disable-capture-restriction:** make compatible with latest versions ([ReVanced#2095](ReVanced/revanced-patches#2095)) ([e48f127](ReVanced/revanced-patches@e48f127)) * **twitter:** correctly resolve to integrations methods ([c655416](ReVanced/revanced-patches@c655416)) * **youtube/custom-video-speed:** add missing class for `video-speeds` patch ([ReVanced#2137](ReVanced/revanced-patches#2137)) ([758ef42](ReVanced/revanced-patches@758ef42)) * **youtube/integrations:** allow playback of embedded videos ([ReVanced#2092](ReVanced/revanced-patches#2092)) ([8a43d75](ReVanced/revanced-patches@8a43d75)) * **youtube/minimized-playback:** update settings description ([ReVanced#2191](ReVanced/revanced-patches#2191)) ([a561a9a](ReVanced/revanced-patches@a561a9a)) * **youtube/remember-video-quality:** fix default video quality/speed being applied when resuming app. ([ReVanced#2112](ReVanced/revanced-patches#2112)) ([f68a41c](ReVanced/revanced-patches@f68a41c)) * **youtube/return-youtube-dislikes:** fix temporarily frozen video after opening a shorts ([ReVanced#2126](ReVanced/revanced-patches#2126)) ([e0877e3](ReVanced/revanced-patches@e0877e3)) * **youtube/settings:** fix non functional back button in settings ([ReVanced#2178](ReVanced/revanced-patches#2178)) ([46da834](ReVanced/revanced-patches@46da834)) * **youtube/sponsorblock:** fix skip button in wrong location when full screen and comments visible ([ReVanced#2051](ReVanced/revanced-patches#2051)) ([30a954c](ReVanced/revanced-patches@30a954c)) * **youtube/sponsorblock:** fix toast shown when scrubbing thru a paused video ([ReVanced#2152](ReVanced/revanced-patches#2152)) ([c6c23ff](ReVanced/revanced-patches@c6c23ff)) * **youtube/spoof-signature-verification:** adjusting summary text ([ReVanced#2169](ReVanced/revanced-patches#2169)) ([4ccb1ee](ReVanced/revanced-patches@4ccb1ee)) * **youtube/theme:** apply custom seekbar color to video thumbnails ([ReVanced#2085](ReVanced/revanced-patches#2085)) ([d497027](ReVanced/revanced-patches@d497027)) * **youtube/theme:** move options out of dependency patch ([a953448](ReVanced/revanced-patches@a953448)) * **youtube/vanced-microg-support:** depend on `client-spoof` patch ([83a4905](ReVanced/revanced-patches@83a4905)) * **youtube/video-speed:** add compatibility annotation ([ReVanced#2156](ReVanced/revanced-patches#2156)) ([ffa2e5d](ReVanced/revanced-patches@ffa2e5d)) * **youtube:** add missing compatibility annotations for `theme` and `hide-load-more-button` ([ReVanced#2150](ReVanced/revanced-patches#2150)) ([78803f8](ReVanced/revanced-patches@78803f8)) ### Features * add capability to filter from protobuf buffer ([b738b6b](ReVanced/revanced-patches@b738b6b)) * **candylinkvpn:** add `unlock-pro` patch ([ReVanced#2157](ReVanced/revanced-patches#2157)) ([7159f86](ReVanced/revanced-patches@7159f86)) * improve structure of `README` ([279b193](ReVanced/revanced-patches@279b193)) * **messenger:** add `disable-switching-emoji-to-sticker-in-message-input-field` patch ([ReVanced#2099](ReVanced/revanced-patches#2099)) ([ac5532a](ReVanced/revanced-patches@ac5532a)) * **messenger:** add `disable-typing-indicator` patch ([ReVanced#2115](ReVanced/revanced-patches#2115)) ([5d1de4f](ReVanced/revanced-patches@5d1de4f)) * **patch:** bump compatibility ([ReVanced#2060](ReVanced/revanced-patches#2060)) ([f86836d](ReVanced/revanced-patches@f86836d)) * **reddit:** add `sanitize-sharing-links` patch ([ReVanced#2192](ReVanced/revanced-patches#2192)) ([9593e4b](ReVanced/revanced-patches@9593e4b)) * **reddit:** remove compatibility version constraints ([ReVanced#2226](ReVanced/revanced-patches#2226)) ([f1288e4](ReVanced/revanced-patches@f1288e4)) * **syncforreddit:** add `disable-ads` patch ([ReVanced#2066](ReVanced/revanced-patches#2066)) ([c1de5d6](ReVanced/revanced-patches@c1de5d6)) * **trakt:** add `unlock-pro` patch ([ReVanced#2210](ReVanced/revanced-patches#2210)) ([1e8dcae](ReVanced/revanced-patches@1e8dcae)) * **twitch/auto-claim-channel-points:** use correct casing for "Channel Points" ([ReVanced#2138](ReVanced/revanced-patches#2138)) ([76a3bf2](ReVanced/revanced-patches@76a3bf2)) * **twitch:** add `auto-claim-channel-points` patch ([ReVanced#2131](ReVanced/revanced-patches#2131)) ([80fb670](ReVanced/revanced-patches@80fb670)) * use consistent names for patches ([6347146](ReVanced/revanced-patches@6347146)) * **vsco:** add `unlock-pro` patch ([ReVanced#2168](ReVanced/revanced-patches#2168)) ([7ffd1a0](ReVanced/revanced-patches@7ffd1a0)) * **youtube/copy-video-url:** add tap and hold functionality to copy video url buttons ([ReVanced#2174](ReVanced/revanced-patches#2174)) ([95bbf46](ReVanced/revanced-patches@95bbf46)) * **youtube/downloads:** improve patch description ([e0f6452](ReVanced/revanced-patches@e0f6452)) * **youtube/hide-filter-bar:** add `PreferenceScreen` summary ([2bba5f7](ReVanced/revanced-patches@2bba5f7)) * **youtube/hide-player-overlay:** make it toggleable in settings ([ReVanced#2044](ReVanced/revanced-patches#2044)) ([f693d55](ReVanced/revanced-patches@f693d55)) * **youtube/hide-shorts-components:** hide navigation bar ([24f376a](ReVanced/revanced-patches@24f376a)) * **youtube/settings:** add reset button to edit preference dialog ([ReVanced#2047](ReVanced/revanced-patches#2047)) ([ede765a](ReVanced/revanced-patches@ede765a)) * **youtube/video-speed:** change custom video speeds inside app settings ([ReVanced#2114](ReVanced/revanced-patches#2114)) ([d97815a](ReVanced/revanced-patches@d97815a)) * **youtube:** `hide-load-more-button` patch ([ReVanced#2078](ReVanced/revanced-patches#2078)) ([7170802](ReVanced/revanced-patches@7170802)) * **youtube:** add `hide-filter-bar` patch ([6cc5f61](ReVanced/revanced-patches@6cc5f61)) * **youtube:** add `hide-shorts-components` patch ([64868f4](ReVanced/revanced-patches@64868f4)) * **youtube:** add options to disable toasts on connection error ([ReVanced#2159](ReVanced/revanced-patches#2159)) ([99916ae](ReVanced/revanced-patches@99916ae)) * **youtube:** constrain patches to `18.16.37` ([758b300](ReVanced/revanced-patches@758b300)) * **youtube:** import / export of revanced settings ([ReVanced#2077](ReVanced/revanced-patches#2077)) ([b59cb3e](ReVanced/revanced-patches@b59cb3e)) * **youtube:** move video settings to `Video` settings category ([ReVanced#2010](ReVanced/revanced-patches#2010)) ([f4b9180](ReVanced/revanced-patches@f4b9180)) * **youtube:** support version `18.19.35` ([491f292](ReVanced/revanced-patches@491f292))
Application
YouTube Revanced
Issue
To get more accurate preview when doing sponsorblock submission from YouTube revanced so it will make it easier for the contributors to make better quality segments while the users of sponsorblock get the benefits of better quality segments.
Patch
Let the user set custom playback speed value such as 0.85x, 0.80x or even better to any value.
Motivation
The preview from sponsorblock is not accurate.
When we set at normal playback speed or 1x, the preview you get is late while the opposite happen when the playback speed set at 0.75x. Based on that, the right value to get accurate preview must be higher than 0.75x but lower than 1x.
So by allowing users to set custom playback speed it is possible to get much more accurate preview that will result in better quality segment submissions and much more easier for contributors to make good quality segments that will improve users experience.
The text was updated successfully, but these errors were encountered: