Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube): Show subtitles / captions in PiP mode & tablet mini player #1164

Closed
3 tasks done
castdrian opened this issue Apr 12, 2023 · 5 comments
Closed
3 tasks done
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@castdrian
Copy link

castdrian commented Apr 12, 2023

Application

YouTube

Issue

YouTube subtitles aren't displayed in PiP mode/tablet miniplayer because they're some screen overlay that just gets disabled

Patch

Ideally the captions would be visible in PiP mode and tablet miniplayer

Motivation

It seems reasonable that captions shouldn't disappear, whilst you're watching something

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@castdrian castdrian added the Feature request Requesting a new feature that's not implemented yet label Apr 12, 2023
@oSumAtrIX
Copy link
Member

Captions would block the entire view to videos. This patch is not feasible properly, likely why YouTube also did not implement it natively.

@castdrian
Copy link
Author

I would like to mention that Netflix has this working perfectly fine by just scaling down the subtitles appropriately with the PiP window, but alas this can stay closed as it's probably too challenging to implement either way.

@oSumAtrIX
Copy link
Member

Doesn't look too small, i imagined it worse. This request would need a patch to disable the behavior of turning off subtitles when going into PiP.

@oSumAtrIX oSumAtrIX reopened this Apr 15, 2023
@pritkr
Copy link

pritkr commented Apr 16, 2023

Mpv shows subtitles in a good way in android for reference-
Screenshot_20230416-095838_One UI Home
Screenshot_20230416-095758_One UI Home
![Screenshot_20230416-095838_One UI Home]
I wanted to see this feature in youtube for a long time

@castdrian castdrian changed the title feat(patch): show subtites/captions in PiP mode feat(patch): show subtites/captions in PiP mode & tablet miniplayer Apr 17, 2023
@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat(patch): show subtites/captions in PiP mode & tablet miniplayer feat(YouTube): Show subtitles / captions in PiP mode & tablet mini player Apr 2, 2024
@oSumAtrIX
Copy link
Member

Over time, a lot of feature requests have been made, which is why I am closing some according to the contribution guidelines:

Requests can be accepted or rejected at the discretion of maintainers of ReVanced Patches

This feature request has been closed for one or more of the following reasons:

  • Stale for too long
  • Low priority
  • Maintainers un-interested
  • Too complex to realize

Regardless, anyone who comes across this feature request can PR it. Thanks for the feature request!

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

3 participants