Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"interaction Window" doesn't appear at the right place #1120

Closed
3 tasks done
xDARKxDEVILx opened this issue Apr 21, 2023 · 38 comments
Closed
3 tasks done

"interaction Window" doesn't appear at the right place #1120

xDARKxDEVILx opened this issue Apr 21, 2023 · 38 comments
Labels
Bug report Something isn't working

Comments

@xDARKxDEVILx
Copy link

Type

Error at runtime

Bug description

This issue is only related to the tablet version, which only happened like a week ago by its own (without any update to the app or patches) and it is that this window appear at the wrong place, some examples are provided below but it happens with all " : " buttons

Steps to reproduce

Click on any " : " button and you will find that the window apears at top left regardless of where it should appear

Relevant log output

No log

Screenshots or videos

Screenshot_20230416-172909

IMG_20230416_173645

Solution

No response

Additional context

This bug is extremely annoying so please try to fix it asap, it only happens in ReVanced btw

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@xDARKxDEVILx xDARKxDEVILx added the Bug report Something isn't working label Apr 21, 2023
@Masamune3210
Copy link

I really wish people would stop putting asap in their reports. The devs owe you nothing and do it as a side-project usually. Insisting on a time schedule isn't going to end well

@xDARKxDEVILx
Copy link
Author

I really wish people would stop putting asap in their reports. The devs owe you nothing and do it as a side-project usually. Insisting on a time schedule isn't going to end well

Well, this bug is really annoying so i just asked them to prioritize it , and i think i asked kindly i am really appreciative of their work and i don't think i requested it like if "they owe me something" and at the end it won't change that they can reglect or delay the fix

@oSumAtrIX
Copy link
Member

Check the stock unpatched app (same version).

@oSumAtrIX oSumAtrIX added the Waiting on author Further information is requested label Apr 21, 2023
@xDARKxDEVILx
Copy link
Author

Check the stock unpatched app (same version).

Doesn't happen to stock app for any version only revanced

@xDARKxDEVILx
Copy link
Author

I checked version 18.05.40 and 18.08.37 and it is fine for both of them

@oSumAtrIX
Copy link
Member

Exclude patches from the patching process until the error is gone, and report back which one causes it.

@xDARKxDEVILx
Copy link
Author

Exclude patches from the patching process until the error is gone, and report back which one causes it.

Any suggestions for what patches may cause it? as trying excluding every single patch will take me three weeks lol

@oSumAtrIX
Copy link
Member

You can do a binary search that would find the problematic patch in log(patchesCount) time in the fastest way possible.

@xDARKxDEVILx
Copy link
Author

You can do a binary search that would find the problematic patch in log(patchesCount) time in the fastest way possible.

I don't know why you thought i would understand that, can you please explain what you mean better? If it is difficult then don't explain 🙂

@oSumAtrIX
Copy link
Member

I don't know why you thought I would understand that

CS students should be aware of binary search:

image

Say you have a list of patches. Exclude half of them; if the issue persists, the problematic patch is in the other half. Proceed to do the same to that half.

@xDARKxDEVILx
Copy link
Author

xDARKxDEVILx commented Apr 21, 2023

I don't know why you thought I would understand that

CS students should be aware of binary search:

image

Say you have a list of patches. Exclude half of them; if the issue persists, the problematic patch is in the other half. Proceed to do the same to that half.

Nope they haven't taught as that yet lol, but i was actually doing that now without understanding it , i narrowed the patches to 8 and will continue testing

@xDARKxDEVILx
Copy link
Author

xDARKxDEVILx commented Apr 21, 2023

It is one of these since the apk patched with them still have the issue

@oSumAtrIX
Copy link
Member

Please reupload the image.

@xDARKxDEVILx
Copy link
Author

Screenshot_2023-04-22-01-21-04-575_app revanced manager flutter

@oSumAtrIX
Copy link
Member

Narrow down even more.

@xDARKxDEVILx
Copy link
Author

Narrow down even more.

Still exists with these 4
Screenshot_2023-04-22-01-38-35-417_app revanced manager flutter

@xDARKxDEVILx
Copy link
Author

It is probably the spoof one then, i will try again only it and microG

@xDARKxDEVILx
Copy link
Author

xDARKxDEVILx commented Apr 21, 2023

Somehow it still exists with only microg patch

@oSumAtrIX
Copy link
Member

In that case it is a stock issue.

@xDARKxDEVILx
Copy link
Author

In that case it is a stock issue.

But i tested stock and it is fine🥲

@xDARKxDEVILx
Copy link
Author

Will test it again

@xDARKxDEVILx
Copy link
Author

Yeah stock is perfectly fine, i am not an idiot nor am i lying, the stock version has no issue and the patched one with only MicroG patch has the issue

@xDARKxDEVILx
Copy link
Author

xDARKxDEVILx commented Apr 22, 2023

I said before that this issue happened without any change in anything, slept with ReVanced fine and woke up without updating anything and the issue apeared , but it can't be from YouTube side as stock is perfectly fine, i have no idea what it could be then

@xDARKxDEVILx
Copy link
Author

Sorry for too many comments but i can confirm that stock is fine , can you test it yourself or ask someone with any tablet and see if you can figure out the issue? Appreciate your help

@oSumAtrIX
Copy link
Member

Did you install the same apk you are patching without patching it and did you check if it happens there?

@xDARKxDEVILx
Copy link
Author

Did you install the same apk you are patching without patching it and did you check if it happens there?

You mean patch without even MicroG support patch or what exactly?

@xDARKxDEVILx
Copy link
Author

The apps i have are Stock V 18.08.37 downloaded from apkmirror and the patched V 18.08.37 one with only MicroG support patch, do you want anything different?

@xDARKxDEVILx
Copy link
Author

The stock actually rarly have the same issue i have no idea how this happens i am starting to lose my mind , five times i open it and it is fine and one time it has the issue

@xDARKxDEVILx
Copy link
Author

Now it always has the issue,so maybe stock doesn't have it for the first few times you open it and then it starts to have the issue , but the patched one always has it ( this may be wrong but that is what i understood)

@xDARKxDEVILx
Copy link
Author

I tried updating to the latest google play version and the issue exists, so does that mean it is YouTube thing? At least reply to this last comment

@oSumAtrIX
Copy link
Member

If it happens in the unpatched app, as originally assumed, yes.

@xDARKxDEVILx
Copy link
Author

If it happens in the unpatched app, as originally assumed, yes.

I am really sorry for wasting your time and it is a YouTube issue , but i really didn't know since it only happened after like the fifth time i open it , i feel like a dummy now lol

@oSumAtrIX
Copy link
Member

All good, happens.

@xDARKxDEVILx
Copy link
Author

All good, happens.

Sorry to bother you, but this issue has not been solved to this day, i have tried sending YouTube this issue but i got no reply and i couldn't provide screenshots anyway, do you know a good way to ask YouTube to fix their damn app?

@oSumAtrIX
Copy link
Member

No, it is an upstream issue and unrelated to ReVanced.

@xDARKxDEVILx
Copy link
Author

xDARKxDEVILx commented May 17, 2023

No, it is an upstream issue and unrelated to ReVanced.

I know i was asking you if you know a way to contact google to fix it , not you guys

Was the "no" for you don't know how to ask yt?

@oSumAtrIX
Copy link
Member

Screenshot_2023-05-17-20-04-18-26_4d38fce200f96aeac5e860e739312e76

@xDARKxDEVILx
Copy link
Author

This bug has finally been fixed after more than 3 months F U YouTube,
i mean Thank you 🙂

@ILoveOpenSourceApplications ILoveOpenSourceApplications removed the Waiting on author Further information is requested label Jun 20, 2023
@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants