Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: home feed auto caption show not working with spoof-signature-verification #1119

Closed
3 tasks done
sodkfjoa opened this issue Apr 21, 2023 · 2 comments
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@sodkfjoa
Copy link

Type

Cosmetic

Bug description

With "Spoof app signature" turned off it always shows captions in the home and subscriptions feed automatically when auto-play starts no matter if captions are turned on or off in YouTube settings. But with spoof on, if the video has auto-generated captions, it doesn't automatically show the captions, I have to click on the cc button each time (interestingly when the video has auto-generated captions, the captions then appear word by word in the feed, but with spoof turned off the captions appear whole lines at a time).

For videos whose captions are not auto-generated, if the captions are on in the YouTube settings, it does show them in the feed both with spoof on and off. With captions off in the YouTube settings, with spoof off it still shows them, but with spoof on doesn't.

Steps to reproduce

Turn on/off spoof app signature and watch an auto-playing video in the home or subscription feed. If for example the captions were auto-generated, the automatic display of the captions goes away turning on the spoof.

Relevant log output

-

Screenshots or videos

No response

Solution

No response

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@sodkfjoa sodkfjoa added the Bug report Something isn't working label Apr 21, 2023
@oSumAtrIX
Copy link
Member

oSumAtrIX commented Apr 21, 2023

The behavior does not differ when the patch is toggled on or off. Leaving open for others to reproduce.

@oSumAtrIX oSumAtrIX added the Waiting on author Further information is requested label Apr 21, 2023
@LisoUseInAIKyrios
Copy link
Contributor

Issue is present again after the latest spoof patch changes.

It appears the CC button was also removed from the feed autoplay (and captions are turned on all the time).

Moving issue to #1752

@LisoUseInAIKyrios LisoUseInAIKyrios removed the Waiting on author Further information is requested label Jun 25, 2023
@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Slenderman00 pushed a commit to Slenderman00/revanced-patches-grindr that referenced this issue Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants