fix(YouTube - Theme): Use dark theme color for status and navigation bar

ReVanced · Dec 22, 2024 · 0240efe · 0240efe
1 parent 7870a15
commit 0240efe
Showing 1 changed file with 22 additions and 13 deletions.
diff --git a/patches/src/main/kotlin/app/revanced/patches/youtube/layout/theme/ThemePatch.kt b/patches/src/main/kotlin/app/revanced/patches/youtube/layout/theme/ThemePatch.kt
@@ -163,22 +163,31 @@ val themePatch = bytecodePatch(
                     }
 
                     // Fix the splash screen dark mode background color.
-                    // In earlier versions of the app this is white and makes no sense for dark mode.
-                    // This is only required for 19.32 and greater, but is applied to all targets.
-                    // Only dark mode needs this fix as light mode correctly uses the custom color.
+                    // In 19.32+ the dark mode splash screen is white and fades to black.
+                    // Maybe it's a bug in YT, or maybe it intentionally. Who knows.
                     document("res/values-night/styles.xml").use { document ->
-                        // Create a night mode specific override for the splash screen background.
-                        val style = document.createElement("style")
-                        style.setAttribute("name", "Theme.YouTube.Home")
-                        style.setAttribute("parent", "@style/Base.V23.Theme.YouTube.Home")
+                        val resourcesNode = document.getElementsByTagName("resources").item(0) as Element
+                        val childNodes = resourcesNode.childNodes
 
-                        val windowItem = document.createElement("item")
-                        windowItem.setAttribute("name", "android:windowBackground")
-                        windowItem.textContent = "@color/$splashBackgroundColor"
-                        style.appendChild(windowItem)
+                        for (i in 0 until childNodes.length) {
+                            val node = childNodes.item(i) as? Element ?: continue
+                            val nodeAttributeName = node.getAttribute("name")
+                            if (nodeAttributeName.startsWith("Theme.YouTube.Launcher")) {
+                                val nodeAttributeParent = node.getAttribute("parent")
 
-                        val resourcesNode = document.getElementsByTagName("resources").item(0) as Element
-                        resourcesNode.appendChild(style)
+                                val style = document.createElement("style")
+                                style.setAttribute("name", "Theme.YouTube.Home")
+                                style.setAttribute("parent", nodeAttributeParent)
+
+                                val windowItem = document.createElement("item")
+                                windowItem.setAttribute("name", "android:windowBackground")
+                                windowItem.textContent = "@color/$splashBackgroundColor"
+                                style.appendChild(windowItem)
+
+                                resourcesNode.removeChild(node)
+                                resourcesNode.appendChild(style)
+                            }
+                        }
                     }
                 }
             }