Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(youtube): bump patches compatibility to v17.43.36 #924

Merged
merged 10 commits into from Nov 1, 2022
Merged

feat(youtube): bump patches compatibility to v17.43.36 #924

merged 10 commits into from Nov 1, 2022

Conversation

ghost
Copy link

@ghost ghost commented Oct 31, 2022 •
edited by ghost
Loading

This was referenced Oct 31, 2022
Closed
Closed
@oSumAtrIX oSumAtrIX marked this pull request as draft October 31, 2022 11:36
@oSumAtrIX
Copy link
Member

Add your other PRs (#926, #925) here, so they can be squashed as one refactor commit.

@ghost ghost changed the title fix(YouTube/hide-album-cards-patch): improved fingerprint reliability feat(youtube): bump patches compatibility to v17.43.36 Oct 31, 2022
@ghost ghost marked this pull request as ready for review October 31, 2022 13:47
@ghost
Copy link
Author

ghost commented Oct 31, 2022

All fingerprints dupes (and related weirdness) has been solved.

@ghost ghost requested a review from oSumAtrIX October 31, 2022 23:07
@ghost
Copy link
Author

ghost commented Oct 31, 2022

The class method patched by hide email address is changed on one of recents YouTube builds, and it causes an app crash with the public available patch.

This PR will fix this problem too.

@Domiiniik

This comment was marked as off-topic.

Sign in to view
@NeeRaj-2401
Copy link

why to bump to a beta version ?
image

@ghost
Copy link
Author

ghost commented Nov 1, 2022

why to bump to a beta version ? image

Why not? All the changes made will be backwards compatible with the previous stable ones. 🤷‍♂️

@NeeRaj-2401
Copy link

NeeRaj-2401 commented Nov 1, 2022 •
edited
Loading

Why not?

beta versions might contain bugs or unfinished/broken features etc and after version bump.. people will use and patch that apk version which might cause some issue

@ghost
Copy link
Author

ghost commented Nov 1, 2022

Why not?

beta versions might contain bugs or unfinished features etc and after version bump.. people will use and patch that apk version which might cause some issue

Everyone is free to choose what to do. In any case, if there were bugs, it's possible to update only to stable version 17.42.35.

johnconner122
johnconner122 reviewed Nov 1, 2022
View reviewed changes
src/main/kotlin/app/revanced/patches/youtube/ad/general/annotation/GeneralAdsCompatibility.kt
@@ -5,7 +5,7 @@ import app.revanced.patcher.annotation.Package

@Compatibility(
[Package(
"com.google.android.youtube", arrayOf("17.19.36", "17.20.37", "17.22.36", "17.23.35", "17.23.36", "17.24.34", "17.24.35", "17.25.34", "17.26.35", "17.27.39", "17.28.34", "17.29.34", "17.32.35", "17.33.42", "17.34.35", "17.34.36", "17.36.37", "17.41.37")
"com.google.android.youtube", arrayOf("17.36.37", "17.41.37", "17.42.35", "17.43.36")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can create separate annotation's package to deduplicate this class, then we can import it where ever we need.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought of this too. Since we have lots of "duplicate" annotations, creating a package for annotations and then importing from there should make commits less heavy and deduplicate code.

Copy link
Author

@ghost ghost Nov 1, 2022 •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah...good idea. I'll work on it later.

@oSumAtrIX oSumAtrIX merged commit 3867514 into ReVanced:main Nov 1, 2022
github-actions bot pushed a commit that referenced this pull request Nov 1, 2022
@semantic-release-bot
chore(release): 2.101.0 [skip ci]
b00fd64 
# [2.101.0](ReVanced/revanced-patches@v2.100.3...v2.101.0) (2022-11-01)

### Features

* **youtube:** bump patches compatibility to v17.43.36 ([#924](ReVanced/revanced-patches#924)) ([3867514](ReVanced/revanced-patches@3867514))
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

🎉 This PR is included in version 2.101.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost deleted the album_cards_fingerprint branch November 1, 2022 19:04
github-actions bot referenced this pull request in TheNoFace/revanced-patches Nov 3, 2022
@semantic-release-bot
chore(release): 2.48.0 [skip ci]
a08a7b6 
# [2.48.0](v2.47.1...v2.48.0) (2022-11-03)

### Features

* **youtube:** bump patches compatibility to v17.43.36 ([#924](https://github.com/TheNoFace/revanced-patches/issues/924)) ([3867514](3867514))
@ghost
Copy link

ghost commented Nov 3, 2022

ReVanced does not open after this version

@ghost
Copy link

ghost commented Nov 3, 2022

Error occurs: Android 12

@johnconner122
Copy link

ReVanced does not open after this version

try YouTube v17.42.35

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Nov 3, 2022 •
edited
Loading

Please open an issue, here is the wrong place.

@ReVanced ReVanced locked as off-topic and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oSumAtrIX @Domiiniik @NeeRaj-2401 @johnconner122