Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compact-header patch #204

Merged
merged 1 commit into from
Jul 18, 2022
Merged

feat: compact-header patch #204

merged 1 commit into from
Jul 18, 2022

Conversation

ponces
Copy link

@ponces ponces commented Jul 18, 2022

This patch is excluded by default.
Based on Vanced's work.

@oSumAtrIX oSumAtrIX merged commit 83753ba into ReVanced:main Jul 18, 2022
@oSumAtrIX
Copy link
Member

Thanks, fyi the root variant for YouTube Music is fixed now.

@github-actions
Copy link

🎉 This PR is included in version 2.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ponces
Copy link
Author

ponces commented Jul 18, 2022

Thanks, fyi the root variant for YouTube Music is fixed now.

How??

@oSumAtrIX
Copy link
Member

The alignment of, the zip entries for libraries is now done properly (4KiB).

@ponces
Copy link
Author

ponces commented Jul 19, 2022

Same issue with missing library after all (which I thought it would work after your fix) 😞
This is described here.

07-19 10:04:03.947 19403 19403 E AndroidRuntime: FATAL EXCEPTION: main
07-19 10:04:03.947 19403 19403 E AndroidRuntime: Process: com.google.android.apps.youtube.music, PID: 19403
07-19 10:04:03.947 19403 19403 E AndroidRuntime: java.lang.UnsatisfiedLinkError: dlopen failed: library "libjsc.so" not found: needed by /data/data/com.google.android.apps.youtube.music/app_lib/libelements.so.5.14.53 in namespace classloader-namespace
07-19 10:04:03.947 19403 19403 E AndroidRuntime: at java.lang.Runtime.load0(Runtime.java:929)
07-19 10:04:03.947 19403 19403 E AndroidRuntime: at java.lang.System.load(System.java:1620)
07-19 10:04:03.947 19403 19403 E AndroidRuntime: at fdd.c(PG:48)
07-19 10:04:03.947 19403 19403 E AndroidRuntime: at xah.a(PG:7)
07-19 10:04:03.947 19403 19403 E AndroidRuntime: at gan.a(PG:1)
07-19 10:04:03.947 19403 19403 E AndroidRuntime: at amhq.b(PG:8)

@ponces ponces deleted the compact-header branch July 19, 2022 10:29
@ghost
Copy link

ghost commented Jul 19, 2022

Aligning is still broken :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants