This repository has been archived by the owner on Oct 26, 2024. It is now read-only.
fix(YouTube - Restore old video quality menu): Do not show error toast if using an old version of YT #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an old version of YT
revanced-bot
pushed a commit
that referenced
this pull request
May 27, 2024
## [1.9.2-dev.2](v1.9.2-dev.1...v1.9.2-dev.2) (2024-05-27) ### Bug Fixes * **YouTube - Restore old video quality menu:** Do not show error toast if using an old version of YT ([#640](#640)) ([2227b45](2227b45))
revanced-bot
pushed a commit
that referenced
this pull request
May 31, 2024
## [1.9.2](v1.9.1...v1.9.2) (2024-05-31) ### Bug Fixes * **YouTube - Restore old video quality menu:** Do not show error toast if using an old version of YT ([#640](#640)) ([2227b45](2227b45)) * **YouTube - Spoof client:** Disable AV1 if not supported by spoofing an older iOS device ([#644](#644)) ([e28edba](e28edba)) * **YouTube - Spoof client:** Improve Android spoofing ([#641](#641)) ([baf967e](baf967e))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On first launch of Android 8.0 (and maybe some slightly newer versions as well), the playback speed and quality menus use whatever is pre-baked into the apk. It's only after a few app restarts does it start using the newer code paths the old quality and custom speed patches expect.
If the speed or quality menu is opened during these initial launches, the menus show the unpatched behavior but also throw exception toasts.
Rather than fix the patch to work for this temporary situation, instead this PR makes the patches more cautious and fallbacks on using the old menus (as if the patches were disabled). After 1 or more app launches the new flyouts are used and the patches then work as expected.