fix: use try/catch to prevent taking down the app if something goes w…

…rong

app/src/main/java/app/revanced/integrations/youtube/settings/preference/ReVancedPreferenceFragment.java

@@ -7,6 +7,7 @@
 
 import androidx.annotation.RequiresApi;
 
+import app.revanced.integrations.shared.Logger;
 import app.revanced.integrations.shared.settings.preference.AbstractPreferenceFragment;
 import app.revanced.integrations.youtube.patches.DownloadsPatch;
 import app.revanced.integrations.youtube.patches.playback.speed.CustomPlaybackSpeedPatch;
@@ -24,22 +25,26 @@ public class ReVancedPreferenceFragment extends AbstractPreferenceFragment {
     protected void initialize() {
         super.initialize();
 
-        // If the preference was included, then initialize it based on the available playback speed
-        Preference defaultSpeedPreference = findPreference(Settings.PLAYBACK_SPEED_DEFAULT.key);
-        if (defaultSpeedPreference instanceof ListPreference) {
-            CustomPlaybackSpeedPatch.initializeListPreference((ListPreference) defaultSpeedPreference);
-        }
+        try {
+            // If the preference was included, then initialize it based on the available playback speed
+            Preference defaultSpeedPreference = findPreference(Settings.PLAYBACK_SPEED_DEFAULT.key);
+            if (defaultSpeedPreference instanceof ListPreference) {
+                CustomPlaybackSpeedPatch.initializeListPreference((ListPreference) defaultSpeedPreference);
+            }
 
-        // Action button hook does not work on older versions.
-        // Remove the preference to make things simpler.
-        if (DownloadsPatch.shouldHideActionButtonOverridePreference()) {
-            Preference downloadActionButton = findPreference(Settings.EXTERNAL_DOWNLOADER_ACTION_BUTTON.key);
-            if (downloadActionButton != null) {
-                PreferenceGroup group = downloadActionButton.getParent();
-                if (group != null) {
-                    downloadActionButton.getParent().removePreference(downloadActionButton);
+            // Action button hook does not work on older versions.
+            // Remove the preference to make things simpler.
+            if (DownloadsPatch.shouldHideActionButtonOverridePreference()) {
+                Preference downloadActionButton = findPreference(Settings.EXTERNAL_DOWNLOADER_ACTION_BUTTON.key);
+                if (downloadActionButton != null) {
+                    PreferenceGroup group = downloadActionButton.getParent();
+                    if (group != null) {
+                        downloadActionButton.getParent().removePreference(downloadActionButton);
+                    }
                 }
             }
+        } catch (Exception ex) {
+            Logger.printException(() -> "initialize failure", ex);
         }
     }
 }

app/src/main/java/app/revanced/integrations/youtube/videoplayer/BottomControlButton.java

@@ -1,6 +1,5 @@
 package app.revanced.integrations.youtube.videoplayer;
 
-import android.content.Context;
 import android.view.View;
 import android.view.ViewGroup;
 import android.view.animation.Animation;
@@ -21,7 +20,6 @@ public abstract class BottomControlButton {
     private static final Animation fadeOut;
 
     private final WeakReference<ImageView> buttonRef;
-    private final WeakReference<Context> activityContextRef;
     private final BooleanSetting setting;
     protected boolean isVisible;
 
@@ -62,12 +60,6 @@ public BottomControlButton(@NonNull ViewGroup bottomControlsViewGroup, @NonNull
         imageView.setVisibility(View.GONE);
 
         buttonRef = new WeakReference<>(imageView);
-        activityContextRef = new WeakReference<>(imageView.getContext());
-    }
-
-    @Nullable
-    public Context getActivityContext() {
-        return activityContextRef.get();
     }
 
     public void setVisibility(boolean visible) {

app/src/main/java/app/revanced/integrations/youtube/videoplayer/ExternalDownloadButton.java

@@ -35,11 +35,6 @@ public static void initializeButton(View view) {
         }
     }
 
-    @Nullable
-    public static ExternalDownloadButton getInstance() {
-        return instance;
-    }
-
     /**
      * Injection point.
      */