Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3029.
NB: This is currently based to #6589 given it touches a very similar aspect of
print.data.table()
(hence cc @aitap too).This constitutes a small breaking change by restoring behavior of
print(DT)
andprint(DT[, a:=b])
to always print. I don't really see a downside of this -- the other tests in autoprint continue to WAI.Does anyone see a reason to maintain the old behavior? @jangorecki @tdhock @ben-schwen. It should be feasible to adjust this PR to make the code a tiny bit more complicated while still achieving the desired fix for #3029 -- I just am not seeing the benefit of that (besides back-compatibility on this pretty minor aspect of the package).
Here's the relevant commit that introduced this behavior: 5d95da3 fixing #1122.
It seems like this PR achieves what that PR couldn't (possibly due to an underlying change in R itself), namely to have
if (TRUE) DT[, a:=b]
andprint(DT)
both not print.