NW6 | Zeliha Pala | Full-Stack-Project | Week-2 | DELETE-A- Video-Recommendation #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for watch-next-cyf ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Ara225
reviewed
May 25, 2024
Comment on lines
+30
to
+41
| router.delete("/videos/:id", async (req, res) => { | ||
| const videoId = req.params.id; | ||
|
|
||
| try { | ||
| await db.query("DELETE FROM videos WHERE id = $1", [videoId]); | ||
| res | ||
| .status(200) | ||
| .json({ success: true, message: "Video deleted successfully" }); | ||
| } catch (error) { | ||
| res | ||
| .status(500) | ||
| .json({ success: false, error: "Failed to delete the video" }); |
There was a problem hiding this comment.
Looking good. I appreciate the use of appropriate HTTP error codes and paramatized queries.
| onDelete(videoId); | ||
| }) | ||
| .catch((error) => { | ||
| console.error(error); |
There was a problem hiding this comment.
Console.error is not a great solution here. The average user never looks in the console so you should make a habit of using a visible error like a alert()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.