Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: dlc1 items typos #201

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Fix: dlc1 items typos #201

merged 5 commits into from
Nov 22, 2023

Conversation

crackedmind
Copy link
Collaborator

No description provided.

TheNasbit
TheNasbit approved these changes Nov 22, 2023
View reviewed changes
Copy link

@TheNasbit TheNasbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, seems i missed some things, thanks for that.

@TheNasbit
Copy link

TheNasbit commented Nov 22, 2023 •
edited
Loading

@crackedmind You could add some changes, so we can do it with a single PR:

In GameStrings.resx:

  • Change "Bright Steel Ring" (Ring_BrightSteelRing) to "Dull Steel Ring", the keyword remains the same, but the name changed in game.
  • Key "Mod_RingOfSpears" is "Ring Of Spears"
  • Key "Mod_ChainOfCommand" is "Chain Of Command"

I forgot them in my first PR as well.

@crackedmind
Copy link
Collaborator Author

@TheNasbit done

@Razzmatazzz Razzmatazzz merged commit 7370e23 into Razzmatazzz:main Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razzmatazzz Razzmatazzz Razzmatazzz approved these changes

@TheNasbit TheNasbit TheNasbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crackedmind @TheNasbit @Razzmatazzz