Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leftovers of random_in_unit_sphere #1637

Open
whydoubt opened this issue Sep 10, 2024 · 1 comment
Open

Leftovers of random_in_unit_sphere #1637

whydoubt opened this issue Sep 10, 2024 · 1 comment
Assignees
@hollasch
Labels
area: book level: patch
Milestone
v4.0.2

Comments

@whydoubt
Copy link
Contributor

There are still a couple of mentions of random_in_unit_sphere in the books,
that should probably be switched out for random_unit_vector:

  • For IOW, it's referenced when adding random_in_unit_disc.
  • For TROYL, it's used as an example of a Las Vegas algorithm.
    random_in_unit_disc would work too, and would be a smaller code snippet.
@hollasch hollasch self-assigned this Nov 12, 2024
@hollasch hollasch added this to the v4.0.2 milestone Nov 12, 2024
@hollasch
Copy link
Collaborator

Ref #1606, #1616

hollasch added a commit that referenced this issue Nov 14, 2024
@hollasch
Fix dangling references to random_in_unit_sphere()
4901620 
Resolves #1637
@hollasch hollasch mentioned this issue Nov 14, 2024
Merged
hollasch added a commit that referenced this issue Nov 15, 2024
@hollasch
Fix dangling references to random_in_unit_sphere()
25b8ba8 
Resolves #1637
@MaliusArth MaliusArth mentioned this issue Dec 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hollasch hollasch

Labels
area: book level: patch
Projects
None yet
Milestone
v4.0.2
Development

No branches or pull requests
2 participants
@hollasch @whydoubt