Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to view Rewind for a previous year #55

Closed
RaunoT opened this issue Dec 31, 2023 · 6 comments · Fixed by #233
Closed

Ability to view Rewind for a previous year #55

RaunoT opened this issue Dec 31, 2023 · 6 comments · Fixed by #233
Assignees
Labels
good first issue Good for newcomers priority:low Low priority released on @develop Released on develop channel type:enhancement New feature or request

Comments

@RaunoT
Copy link
Owner

RaunoT commented Dec 31, 2023

Description

We should be able to optionally set the year for which we want to see the Rewind for.
Currently it's showing it for the ongoing year only.

Desired behavior

The Rewind year could be set in the .env file.

Additional context

No response

@RaunoT RaunoT added type:enhancement New feature or request priority:high High priority labels Dec 31, 2023
@RaunoT RaunoT self-assigned this Dec 31, 2023
@RaunoT RaunoT added priority:medium Medium priority and removed priority:high High priority labels Jan 2, 2024
@RaunoT
Copy link
Owner Author

RaunoT commented Jan 3, 2024

The issue I'm facing with implementing this currently is that we're using get_home_stats to fetch the "Top 5" media items from Tautulli, but that query only supports time_range. I was thinking we could use get_history, which supports the before and after params, but for shows/audio, it only returns the single items (episode or track) instead of the grouped parent.

Having had a quick look, it seems like aunefyren/wrapperr is using get_history to basically pull in all the information and transform it as needed. I'm not a fan of this approach, since from what I can understand, his app builds all the data at buildtime, plex-rewind fetches it dynamically/real-time which is not a behaviour I'm looking to change.

@RaunoT
Copy link
Owner Author

RaunoT commented Jan 4, 2024

A workaround solution, or even a permanently different approach, would be to just always get Rewind for the past 365 days instead of the current year.

Would love to hear what others think.

@RaunoT RaunoT added the help wanted Extra attention is needed label Jan 4, 2024
@RaunoT RaunoT changed the title Add option to view Rewind for previous year Ability to view Rewind for previous year Jan 4, 2024
@tarunkumar519
Copy link

getting rewind for the past year by default seems great. Only few people may want to use rewind for a year at the end of current year. By default getting rewind for last year should be enough.

@RaunoT RaunoT changed the title Ability to view Rewind for previous year Ability to view Rewind for a previous year Jan 8, 2024
@RaunoT
Copy link
Owner Author

RaunoT commented Jan 8, 2024

This behaviour has been altered in 1.7.1.
Until get_home_stats can be updated, Rewind will get data for the past 365 days instead of the astronomical year.
Dashboard "this year" has also been changed to "past year".

@RaunoT RaunoT added priority:low Low priority and removed priority:medium Medium priority labels Jan 8, 2024
@RaunoT RaunoT removed their assignment Jan 10, 2024
@RaunoT RaunoT removed the help wanted Extra attention is needed label Jul 12, 2024
@RaunoT
Copy link
Owner Author

RaunoT commented Jul 27, 2024

This feature has since been added in a new version of Tautulli. Will explore options of adding this into the new settings page.

@RaunoT RaunoT added priority:maybe-someday Lowest priority, requires further consideration good first issue Good for newcomers and removed priority:low Low priority labels Jul 27, 2024
@RaunoT RaunoT added priority:low Low priority and removed priority:maybe-someday Lowest priority, requires further consideration labels Aug 20, 2024
@RaunoT RaunoT self-assigned this Aug 21, 2024
@RaunoT RaunoT added the released on @develop Released on develop channel label Aug 23, 2024
@RaunoT
Copy link
Owner Author

RaunoT commented Aug 23, 2024

🎉 This issue has been resolved in version 4.1.0-develop.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers priority:low Low priority released on @develop Released on develop channel type:enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants