Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade reason-future to Support ReScript 11+ #57

Merged

Conversation

nicktytarenko
Copy link
Collaborator

@nicktytarenko nicktytarenko commented Nov 25, 2024

This PR migrates reason-future from ReasonML to the latest ReScript syntax (v11+). The main objective of this update is to maintain compatibility with ReScript 11+ while preserving the existing functionality and ensuring minimal disruption for current users.

Key Changes

  1. README Updated: Reflects the transition from ReasonML to ReScript with updated examples.
  2. Tests Adapted: Adjusted existing tests to the new ReScript syntax without altering logic or functionality.
  3. File Extensions Renamed: All .re files were converted to .res.
  4. Configuration Updated: Migrated bsconfig.json to rescript.json.
  5. Core Module Switched: Replaced Belt with @rescript/core for better compatibility with ReScript 11+.
  6. Backward Compatibility Maintained: Ensured the library's API and syntax remain consistent to minimize breaking changes for users.
  7. Curried vs. Uncurried Functions: Addressed issues where curried functions following uncurried ones are no longer fused in ReScript 11+.

Context

ReScript 11 introduced significant breaking changes, removing support for the legacy Reason syntax (.re). This migration ensures the library remains functional for users on ReScript 11+.

  • For ReasonML or ReScript ≤v10 Users: They can continue using [email protected].
  • For ReScript 11+ Users: This updated version is necessary to maintain compatibility.

Additional Note

Consider renaming the npm package (e.g., rescript-future) to better reflect its focus on ReScript, following examples like the transition from @glennsl/bs-jest to @glennsl/rescript-jest.

@nicktytarenko nicktytarenko changed the title Upgrade rescirpt to v11 Upgrade reason-future to Support ReScript 11+ Nov 26, 2024
@nicktytarenko nicktytarenko marked this pull request as ready for review November 26, 2024 08:32
@nicktytarenko nicktytarenko merged commit b0e40ee into RationalJS:master Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant