Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to reject a future by calling
Future.error
or by raising in a callback.After our small exchange yesterday on discord, I got interested and started experimenting with handling exceptions, and this is the result :)
One thing to consider before merging this is that catching exceptions doesn't seem to be sound in bucklescript, at least to my understanding, because js can throw whatever, not just
Error
objects.I don't know if this is a showstopper for you, but I thought a PR could at least serve as a reference
if it is.
Otherwise, I was not sure what to name the equivalent of
catch
because naming itflatMapError
was out of the question, so I named it...catch
, but you might have a better idea?