Exception in callback #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure how this should be handled?
Here are the exception problems in order of (imho) severity. * fromPromise (exception in callback) This is particulary insidious because it effectively squelches the error unless the user has the [unhandled-rejection] process handler defined. * mapOk (async exception) This causes problems because the exception is can't be caught by a traditional try/catch mechanism. Wrapping the call in a Promise may be a solution, though a bad one I think. * mapOk (sync exception) because of the synchronous context this exception may be caught, but the behavior is surprising, to me a least. [unhandled-rejection]: https://nodejs.org/api/process.html#process_event_unhandledrejection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #14