Endpoints urls with slash #3824
Conversation
| "target server supports trailing slashes for this " | ||
| "endpoint.".format(base) | ||
| ) | ||
| return base | ||
|
|
||
| url = base | ||
| if not base.endswith("/"): |
There was a problem hiding this comment.
@wochinge I'm not exactly sure what's going on here -- above, we throw a debug message(and previously stripped the slash) if there was one, and then below we add one back on?
There was a problem hiding this comment.
I decided against, cause if subpath values are added by Rasa code (and not externally) and we should know what we are doing and if we add a slash or not.
There was a problem hiding this comment.
Ah okay I got it, I was confused bc i was missing that these were 2 cases with and w/o subpath
| "target server supports trailing slashes for this " | ||
| "endpoint.".format(base) | ||
| ) | ||
| return base | ||
|
|
||
| url = base | ||
| if not base.endswith("/"): |
There was a problem hiding this comment.
Ah okay I got it, I was confused bc i was missing that these were 2 cases with and w/o subpath
|
Still doesnt solve the 404 issue. Please help |
|
@Wing-e7 please open a bug report with full information and ideally reproducible behavior if you think there is still a bug! |
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)