WineResolver: Do not unset 'DISPLAY' when running silently #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When unsetting DISPLAY, Wine hangs after executing a command, and doesn't allow for other instances of wine to start, i.e. games do not launch, with a cryptic error. This also fixes the previously observed issues with `winepath.exe` and `reg.exe` never exiting. This is likely due to the newly introduced Wayland driver. This behavior can be observed when Wayland support is compiled into Wine and the wayland driver is enabled in the prefix's registry. In this case, if running under X11 and DISPLAY is not set, Wine will hang, and the process never returns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unsetting DISPLAY, Wine hangs after executing a command, and doesn't allow for other instances of wine to start, i.e. games do not launch, with a cryptic error. This also fixes the previously observed issues with
winepath.exeandreg.exenever exiting.This is likely due to the newly introduced Wayland driver. This behavior can be observed when Wayland support is compiled into Wine and the wayland driver is enabled in the prefix's registry. In this case, if running under X11 and DISPLAY is not set, Wine will hang, and the process never returns.