Shop refactor #269
Closed
Shop refactor #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loathingKernel
force-pushed
the
shop_refactor
branch
from
5539be6 to
32a1774
Compare
loathingKernel
force-pushed
the
shop_refactor
branch
5 times, most recently
from
7c514f6 to
d581d70
Compare
loathingKernel
force-pushed
the
shop_refactor
branch
2 times, most recently
from
d52ed00 to
a2447fa
Compare
loathingKernel
force-pushed
the
shop_refactor
branch
10 times, most recently
from
cc7e5cb to
1d40bb4
Compare
loathingKernel
force-pushed
the
shop_refactor
branch
from
1d40bb4 to
734630a
Compare
loathingKernel
force-pushed
the
shop_refactor
branch
from
734630a to
cbcdc78
Compare
loathingKernel
force-pushed
the
shop_refactor
branch
from
cbcdc78 to
4447e06
Compare
loathingKernel
force-pushed
the
shop_refactor
branch
from
4447e06 to
b0fd6c6
Compare
loathingKernel
force-pushed
the
shop_refactor
branch
7 times, most recently
from
cfc5dc8 to
49a03a5
Compare
…back * Extend `get_wine_prefix` and `get_wine_prefixes` to take Proton prefixes into account.
is unavailable (for example running in a gamescope session) * Do not show the launch window while instantiating the application. This probably was causing numerous issues because it was running outside of the applications event loop. This also fixes the exit button on the login dialog requiring `sys.exit()` to quit Rare. Now it goes through the proper cleanup procedures. * Make slot and signal names more uniform * Fix a problem with RareCore connecting RareGames to the same signals multiple times when the library was refreshed.
It can mess up theming.
Yes, we are back at this. Entitlements are important to have early as Ubisoft redemption requires them, and they don't depend on anything else. * Move config helper initialization into RareCore to make it available earlier.
This probably should be split into separate wine and proton discovery functions.
This allows compatibility tools that use the SteamAppId environment variable to make decisions or apply fixes do their job more accurately. Also use the stored variable to provide a link to protondb through the grade label in GameInfo. The steam grades now use the orjson library to load Steam's ~6MB database faster.
…game's metadata The setting doesn't have a switch in the GUI yet, but the settings feels like a better place for it.
* Use `vars()` instead of directly accessing `__dict__` * Remove `auto_update` from RareGame's metadata * Correct check for updating the Steam App ID (We want to keep any changes from the user) * Collect both Wine and Proton prefixes when removing overlay registry keys. * Add few convenience functions in config_helper and paths.
Important changes: * Refactored QtRequests to accept parameters for `GET` operations * Infer response data type from content-type header * Support caching to disk, a manager with this set prefers the cache * Support multiple handlers for a single request (unused, possibly pointeless) * Subclass `ShopImageWidget` for all widgets used in the shop * Request a resized image instead of the original one * Fix the search and browse functions
loathingKernel
force-pushed
the
shop_refactor
branch
from
49a03a5 to
14e842e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.