Fix issue with author changing type #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cycling through the attributes of the data json 'author' within 'message' which was previously a user object is overwritten with a dictionary. This causes an AttributeError to be thrown ( and silently swallowed... thanks except: pass) whenever any of its attributes are referenced in the form message.author.x. User data should change in this step and the user object should not be modified for any reason so its safe to skip updating it.
|
I had to rebase it since I was working on some stuff. |
|
Somewhat unrelated to this PR but I added an |
ghost
mentioned this pull request
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
Closed
3 tasks
3 tasks
3 tasks
4 tasks
3 tasks
This was referenced Jun 20, 2022
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
JavaProgswing
added a commit
to JavaProgswing/discord.py
that referenced
this pull request
Oct 13, 2023
3 tasks
3 tasks
3 tasks
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cycling through the attributes of the data json 'author' within 'message' which was previously a user object is overwritten with a dictionary. This causes an AttributeError to be thrown ( and silently swallowed... thanks except: pass) whenever any of its attributes are referenced in the form message.author.x. User data should change in this step and the user object should not be modified for any reason so its safe to skip updating it.