Skip to content

Commit

Permalink
(dsccommunity#567) Fix CICD
Browse files Browse the repository at this point in the history
CICD in Azure Devops appears to be broken.

Adding all of the features under `Web-Server` was breaking in
Server 2019 core, was not capable of easily adding the .NET3.5 features.
It turned out that those features were not required so they were
dropped in favor of a more granular set of features for that image.

SSL downloads from the technet gallery were broken in the unit tests
due to incorrect TLS protocol.

The `win1803` server core image and the Windows 2012r2 image
`vs2015-win2012r2` are both being dropped from Azure Devops Pipelines
and have both been replaced in this commit by `vs2017-win2016` as per
Microsofts recommendation at https://devblogs.microsoft.com/devops/removing-older-images-in-azure-pipelines-hosted-pools/
  • Loading branch information
RandomNoun7 committed Feb 25, 2020
1 parent 59e8dcc commit 9183cbb
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 3 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ For older change log history see the [historic changelog](HISTORIC_CHANGELOG.md)
- xWebAdminstration
- Integration tests are running on more Microsoft-hosted agents to
test all possible operating systems ([issue #550](https://github.com/PowerShell/xWebAdministration/issues/550)).
- Fix a few lingering bugs in CICD ([issue #567](https://github.com/PowerShell/xWebAdministration/issues/567))

### Changed

Expand Down
15 changes: 12 additions & 3 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ stages:
- job: Test_Unit
displayName: 'Unit'
pool:
vmImage: 'win1803'
vmImage: 'vs2017-win2016'
timeoutInMinutes: 0
steps:
- powershell: |
Expand Down Expand Up @@ -116,7 +116,7 @@ stages:
- job: Test_Integration_2012R2
displayName: 'Integration 2012R2'
pool:
vmImage: 'vs2015-win2012r2'
vmImage: 'vs2017-win2016'
timeoutInMinutes: 0
steps:
- task: DownloadBuildArtifacts@0
Expand Down Expand Up @@ -251,7 +251,16 @@ stages:
- powershell: |
Set-Service -Name wuauserv -StartupType Manual -Verbose
Start-Service -name wuauserv -Verbose
Install-WindowsFeature -IncludeAllSubFeature -Name 'Web-Server' -Verbose
$features = @(
'Web-Common-Http','Web-Health','Web-Performance',
'Web-Security','Web-AppInit',
'Web-CGI','Web-ISAPI-Ext','Web-ISAPI-Filter',
'Web-Includes','Web-WebSockets', 'Web-Scripting-Tools', 'Web-Mgmt-Tools'
)
foreach($feature in $features) {
Write-Host $feature
Install-WindowsFeature -IncludeAllSubFeature -Name $feature -Verbose
}
name: InstallWebServerFeature
- task: PowerShell@2
name: test
Expand Down
1 change: 1 addition & 0 deletions tests/TestHelper/CommonTestHelper.psm1
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ function Install-NewSelfSignedCertificateExScript
Remove-Item -Path $newSelfSignedCertZipPath -Force
}

[Net.ServicePointManager]::SecurityProtocol = [Net.SecurityProtocolType]::Tls12
Invoke-WebRequest -Uri $newSelfSignedCertURL -OutFile $newSelfSignedCertZipPath

Add-Type -AssemblyName System.IO.Compression.FileSystem
Expand Down

0 comments on commit 9183cbb

Please sign in to comment.