Embed Synced Lyrics with Beets 2.0 + Unpeg Jellyfish Version #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeautifulSoup is needed for Beets lyrics config
hockeygoalie35
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses 2 issues:
#204 [FEATURE] - Updates Beets to 1.6.1 in Lidarr scripts
Beets has a new 2.0 release, and with it comes embedded lyric support. See here for the effects. Implement embedded lyrics, preferring synced lyrics and falling back to static (using Genius and tekstowo as a source). Install BeautifulSoup for static lyrics support per Beets documentation.
Jellyfish pegged at 0.10
This was first found while implementing Feature #187, and a band aid was applied, PR #217 to fix Issue #216. Since the LinuxServer.io image runs on Alpine, a binary needs to be built for musl linux. When the Jellyfish team changed their package to be written in rust, they forgot to build the binary. I pegged Jellyfish at 0.10, the last version before moving to rust. I created an issue here, and they added musl linux to their build chain in the latest version, so it shouldn't be an issue going forward.