Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/fix accessibility issues #40

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Bugfix/fix accessibility issues #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e078d96
Fix text scaling issue
Ramo-Y Oct 28, 2024
a254ce7
Fix Content labeling issue
Ramo-Y Oct 28, 2024
25096f5
Update screenshots with new icons
Ramo-Y Oct 28, 2024
8ecd874
Update what's new
Ramo-Y Oct 28, 2024
7156e15
Update version to 51
Ramo-Y Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .dist/whatsnew/whatsnew-de-DE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@
- Wenn ein neuer Eintrag in Bewegungen gemacht wird, scrollt die App nach unten zu diesem Eintrag
- Speichern und Löschen Icon verändert für bessere Sichtbarkeit
- Aussehen der App verbessert
- Neue Einheit für Distanzen in den Einstellungen hinzugefügt (Einheiteneinstellung wird auf kg zurückgesetzt falls es geändert wurde)
- Neue Einheit für Distanzen in den Einstellungen hinzugefügt (Einheiteneinstellung wird auf kg zurückgesetzt falls es geändert wurde)
- Problem mit der Barrierefreiheit des Speichern-Buttons behoben
3 changes: 2 additions & 1 deletion .dist/whatsnew/whatsnew-en-US
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@
- Pop-up for unsaved changes appears for movements
- Changed save and delete icon for better visibility
- Enhanced look of app
- Added new unit for distances in the settings (unit setting will be reset to kg if it was changed)
- Added new unit for distances in the settings (unit setting will be reset to kg if it was changed)
- Fix an accessibility issue of the save button
Binary file modified .github/images/all_movement_records_view.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified .github/images/movements_view.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project>
<PropertyGroup>
<DisplayVersion>1.0.50</DisplayVersion>
<ApplicationVersion>50</ApplicationVersion>
<DisplayVersion>1.0.51</DisplayVersion>
<ApplicationVersion>51</ApplicationVersion>
<VersionPrefix>$(DisplayVersion)</VersionPrefix>
<ApplicationDisplayVersion>$(DisplayVersion)</ApplicationDisplayVersion>

Expand Down
10 changes: 5 additions & 5 deletions src/PersonalRecord.App/Views/MainView.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,15 +182,15 @@
<DataTemplate>
<Grid MaximumWidthRequest="360">
<Grid.RowDefinitions>
<RowDefinition Height="*"/>
<RowDefinition Height="Auto"/>
<RowDefinition Height="5"/>
<RowDefinition Height="*"/>
<RowDefinition Height="Auto"/>
<RowDefinition Height="5"/>
<RowDefinition Height="2*"/>
<RowDefinition Height="Auto"/>
<RowDefinition Height="5"/>
<RowDefinition Height="*"/>
<RowDefinition Height="Auto"/>
<RowDefinition Height="5"/>
<RowDefinition Height="*"/>
<RowDefinition Height="Auto"/>
</Grid.RowDefinitions>
<Label Grid.Row="0"
Style="{StaticResource DarkLightLabelCustomStyle}"
Expand Down
2 changes: 2 additions & 0 deletions src/PersonalRecord.App/Views/MovementRecordAllView.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

<ContentPage.ToolbarItems>
<ToolbarItem IconImageSource="{AppThemeBinding Dark=save_dark_theme.svg, Light=save_dark_theme.svg}"
SemanticProperties.Description="{x:Static resources:AppResources.Save}"
AutomationProperties.HelpText="{x:Static resources:AppResources.Save}"
Command="{Binding SaveAndGoBackCommand}"/>
</ContentPage.ToolbarItems>

Expand Down
2 changes: 2 additions & 0 deletions src/PersonalRecord.App/Views/MovementsView.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@

<ContentPage.ToolbarItems>
<ToolbarItem IconImageSource="{AppThemeBinding Dark=save_dark_theme.svg, Light=save_dark_theme.svg}"
SemanticProperties.Description="{x:Static resources:AppResources.Save}"
AutomationProperties.HelpText="{x:Static resources:AppResources.Save}"
Command="{Binding SaveAndGoBackCommand}"/>
</ContentPage.ToolbarItems>

Expand Down