Merge pull request #40 from Ramo-Y/bugfix/fix-accessibility-issues

Bugfix/fix accessibility issues
Ramo-Y · Oct 28, 2024 · 63518cc · 63518cc
2 parents bdd6da8 + 7156e15
commit 63518cc
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 9 deletions.
diff --git a/.dist/whatsnew/whatsnew-de-DE b/.dist/whatsnew/whatsnew-de-DE
@@ -2,4 +2,5 @@
 - Wenn ein neuer Eintrag in Bewegungen gemacht wird, scrollt die App nach unten zu diesem Eintrag
 - Speichern und Löschen Icon verändert für bessere Sichtbarkeit
 - Aussehen der App verbessert
-- Neue Einheit für Distanzen in den Einstellungen hinzugefügt (Einheiteneinstellung wird auf kg zurückgesetzt falls es geändert wurde)
+- Neue Einheit für Distanzen in den Einstellungen hinzugefügt (Einheiteneinstellung wird auf kg zurückgesetzt falls es geändert wurde)
+- Problem mit der Barrierefreiheit des Speichern-Buttons behoben
diff --git a/.dist/whatsnew/whatsnew-en-US b/.dist/whatsnew/whatsnew-en-US
@@ -2,4 +2,5 @@
 - Pop-up for unsaved changes appears for movements
 - Changed save and delete icon for better visibility
 - Enhanced look of app
-- Added new unit for distances in the settings (unit setting will be reset to kg if it was changed)
+- Added new unit for distances in the settings (unit setting will be reset to kg if it was changed)
+- Fix an accessibility issue of the save button
diff --git a/.github/images/all_movement_records_view.png b/.github/images/all_movement_records_view.png
diff --git a/.github/images/movements_view.png b/.github/images/movements_view.png
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -1,7 +1,7 @@
 <Project>
   <PropertyGroup>
-    <DisplayVersion>1.0.50</DisplayVersion>
-    <ApplicationVersion>50</ApplicationVersion>
+    <DisplayVersion>1.0.51</DisplayVersion>
+    <ApplicationVersion>51</ApplicationVersion>
     <VersionPrefix>$(DisplayVersion)</VersionPrefix>
     <ApplicationDisplayVersion>$(DisplayVersion)</ApplicationDisplayVersion>
 

diff --git a/src/PersonalRecord.App/Views/MainView.xaml b/src/PersonalRecord.App/Views/MainView.xaml
@@ -182,15 +182,15 @@
                 <DataTemplate>
                     <Grid MaximumWidthRequest="360">
                         <Grid.RowDefinitions>
-                            <RowDefinition Height="*"/>
+                            <RowDefinition Height="Auto"/>
                             <RowDefinition Height="5"/>
-                            <RowDefinition Height="*"/>
+                            <RowDefinition Height="Auto"/>
                             <RowDefinition Height="5"/>
-                            <RowDefinition Height="2*"/>
+                            <RowDefinition Height="Auto"/>
                             <RowDefinition Height="5"/>
-                            <RowDefinition Height="*"/>
+                            <RowDefinition Height="Auto"/>
                             <RowDefinition Height="5"/>
-                            <RowDefinition Height="*"/>
+                            <RowDefinition Height="Auto"/>
                         </Grid.RowDefinitions>
                         <Label Grid.Row="0"
                                Style="{StaticResource DarkLightLabelCustomStyle}"

diff --git a/src/PersonalRecord.App/Views/MovementRecordAllView.xaml b/src/PersonalRecord.App/Views/MovementRecordAllView.xaml
@@ -14,6 +14,8 @@
 
     <ContentPage.ToolbarItems>
         <ToolbarItem IconImageSource="{AppThemeBinding Dark=save_dark_theme.svg, Light=save_dark_theme.svg}"
+                     SemanticProperties.Description="{x:Static resources:AppResources.Save}"
+                     AutomationProperties.HelpText="{x:Static resources:AppResources.Save}"
                      Command="{Binding SaveAndGoBackCommand}"/>
     </ContentPage.ToolbarItems>
 

diff --git a/src/PersonalRecord.App/Views/MovementsView.xaml b/src/PersonalRecord.App/Views/MovementsView.xaml
@@ -14,6 +14,8 @@
 
     <ContentPage.ToolbarItems>
         <ToolbarItem IconImageSource="{AppThemeBinding Dark=save_dark_theme.svg, Light=save_dark_theme.svg}"
+                     SemanticProperties.Description="{x:Static resources:AppResources.Save}"
+                     AutomationProperties.HelpText="{x:Static resources:AppResources.Save}"
                      Command="{Binding SaveAndGoBackCommand}"/>
     </ContentPage.ToolbarItems>