volrep: Fix and simplify archived annotation functions #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirs
force-pushed
the
volrep-archive-annotation
branch
from
9c63833 to
44801de
Compare
We converted int64 to int, possibly truncating the value, and then converted it to string and format the string into the result string. Fixed by formatting int64 into the result string. Signed-off-by: Nir Soffer <[email protected]>
The check is trivial, ensuring that both pvc and pv have the expected annotation value. The code was too complicated, using complex way to access map value, adding 5 temporary variables, and complex conditions. Simplify to the simplest possible form that anyone will understand quickly. Signed-off-by: Nir Soffer <[email protected]>
nirs
force-pushed
the
volrep-archive-annotation
branch
from
44801de to
91dc33c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix and simplify archived annotation value, and the way we check if PVC and PV are already archived.
Result of debugging this CI failure:
https://github.com/RamenDR/ramen/actions/runs/12978252037/job/36221844090