e2e: Improve waiting for drpc readiness #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirs
force-pushed
the
e2e-wait-drpc-ready
branch
from
e962d98 to
b03562c
Compare
|
Marking as draft since it rebased on other PR. |
nirs
force-pushed
the
e2e-wait-drpc-ready
branch
from
b03562c to
4ba901b
Compare
nirs
changed the title
nirs
force-pushed
the
e2e-wait-drpc-ready
branch
2 times, most recently
from
0d8758f to
5235415
Compare
nirs
commented
Dec 4, 2024
nirs
force-pushed
the
e2e-wait-drpc-ready
branch
from
5235415 to
762302d
Compare
Signed-off-by: Nir Soffer <[email protected]>
- Log when we start to wait for readiness - Replace INFO logs with more detailed error on timeout - Replace checkDRPCConditions() with more generic condtionMet() - Use meta.FindStatusConditions to find the conditions - Use ramen.Condition* constants Signed-off-by: Nir Soffer <[email protected]>
For managed apps we waited for Relocated or FailedOver state. For discovered apps we waited for Completed progression. Unify both to wait for the state. Signed-off-by: Nir Soffer <[email protected]>
Inline waitDRPC in the 2 call sites, to make it clear that we wait for the drpc state and then for readiness. Adding trivial wrapper with unclear name is not helpful. Signed-off-by: Nir Soffer <[email protected]>
nirs
force-pushed
the
e2e-wait-drpc-ready
branch
from
762302d to
036af72
Compare
raghavendra-talur
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the implementation and logging when waiting until drpc is ready.
Part of #1686