Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: Fix thread unsafe map access #1591

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Conversation

nirs
Copy link
Member

@nirs nirs commented Oct 21, 2024

  • Protect the map with a mutex
  • Minor cleanups

Fixes #1571

nirs added 3 commits October 21, 2024 18:24
We need only the name for deleting.

Signed-off-by: Nir Soffer <[email protected]>
We modify the textcontext map form multiple tests running in parallel,
so we must synchronize access to the map.

Fixes RamenDR#1571

Signed-off-by: Nir Soffer <[email protected]>
@nirs
Copy link
Member Author

nirs commented Oct 22, 2024

I think #1598 is a better way to fix this issue.

@nirs
Copy link
Member Author

nirs commented Oct 28, 2024

#1606 is also a better way to fix this issue.

@nirs nirs changed the title Fix e2e thread unsafe map access e2e: Fix thread unsafe map access Oct 30, 2024
@ShyamsundarR ShyamsundarR merged commit b4f58e9 into RamenDR:main Oct 31, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e flake: fatal error: concurrent map read and map write
2 participants