-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: Improve storage class names and supported storage checks #1635
Labels
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
test
Testing related issue
Comments
@raghavendra-talur what do you think? |
nirs
added
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
labels
Dec 8, 2024
nirs
added a commit
to nirs/ramen
that referenced
this issue
Dec 11, 2024
We have configuration allowing any storage class name, but the code was hard-coding the names "rook-ceph-block" and "rook-cephfs", limiting the e2e tests to drenv environment. Add a Name key to each PVCSpec entry, eliminating the code to create a suffix. We use the name to crate the name of the test. Part-of: RamenDR#1635 Signed-off-by: Nir Soffer <[email protected]>
nirs
added a commit
to nirs/ramen
that referenced
this issue
Dec 11, 2024
We checked if a deployer supports a workload by checking the hardcoded string "Deploy-cephfs". This wrong it 2 ways, assuming that we use the "Deploy" prefix, and assuming that the storage name is "cephfs". Fix by adding "unsupportedDeployers" lists to PVCSpec. The cephfs default configuration include the "disapp" as unsupported deployer. Move the supported check from the deployer to the workload, since the deployer has no state and it cannot tell if a workload is supported. To make it easier to filter deployers names are now lower case. We anyway use lower case for test names. With this change, we can use any PVCSpec name, and we can keep multiple configurations running all of some the tests. Fixes: RamenDR#1635 Signed-off-by: Nir Soffer <[email protected]>
This was referenced Dec 11, 2024
Open
nirs
added a commit
to nirs/ramen
that referenced
this issue
Dec 11, 2024
We have configuration allowing any storage class name, but the code was hard-coding the names "rook-ceph-block" and "rook-cephfs", limiting the e2e tests to drenv environment. Add a Name key to each PVCSpec entry, eliminating the code to create a suffix. We use the name to crate the name of the test. Part-of: RamenDR#1635 Signed-off-by: Nir Soffer <[email protected]>
nirs
added a commit
to nirs/ramen
that referenced
this issue
Dec 11, 2024
We checked if a deployer supports a workload by checking the hardcoded string "Deploy-cephfs". This wrong it 2 ways, assuming that we use the "Deploy" prefix, and assuming that the storage name is "cephfs". Fix by adding "unsupportedDeployers" lists to PVCSpec. The cephfs default configuration include the "disapp" as unsupported deployer. Move the supported check from the deployer to the workload, since the deployer has no state and it cannot tell if a workload is supported. To make it easier to filter deployers names are now lower case. We anyway use lower case for test names. With this change, we can use any PVCSpec name, and we can keep multiple configurations running all of some the tests. Fixes: RamenDR#1635 Signed-off-by: Nir Soffer <[email protected]>
nirs
added a commit
to nirs/ramen
that referenced
this issue
Dec 11, 2024
We checked if a deployer supports a workload by checking the hardcoded string "Deploy-cephfs". This wrong it 2 ways, assuming that we use the "Deploy" prefix, and assuming that the storage name is "cephfs". Fix by adding "unsupportedDeployers" lists to PVCSpec. The cephfs default configuration include the "disapp" as unsupported deployer. Move the supported check from the deployer to the workload, since the deployer has no state and it cannot tell if a workload is supported. To make it easier to filter deployers, names are now lower case. We anyway use lower case for test names. With this change, we can use any PVCSpec name, and we can keep multiple configurations running all of some the tests. Fixes: RamenDR#1635 Signed-off-by: Nir Soffer <[email protected]>
nirs
added a commit
to nirs/ramen
that referenced
this issue
Dec 11, 2024
We have configuration allowing any storage class name, but the code was hard-coding the names "rook-ceph-block" and "rook-cephfs", limiting the e2e tests to drenv environment. Add a Name key to each PVCSpec entry, eliminating the code to create a suffix. We use the name to crate the name of the test. Part-of: RamenDR#1635 Signed-off-by: Nir Soffer <[email protected]>
nirs
added a commit
to nirs/ramen
that referenced
this issue
Dec 11, 2024
We checked if a deployer supports a workload by checking the hardcoded string "Deploy-cephfs". This wrong it 2 ways, assuming that we use the "Deploy" prefix, and assuming that the storage name is "cephfs". Fix by adding "unsupportedDeployers" lists to PVCSpec. The cephfs default configuration include the "disapp" as unsupported deployer. Move the supported check from the deployer to the workload, since the deployer has no state and it cannot tell if a workload is supported. To make it easier to filter deployers, names are now lower case. We anyway use lower case for test names. With this change, we can use any PVCSpec name, and we can keep multiple configurations running all of some the tests. Fixes: RamenDR#1635 Signed-off-by: Nir Soffer <[email protected]>
raghavendra-talur
pushed a commit
that referenced
this issue
Dec 12, 2024
We have configuration allowing any storage class name, but the code was hard-coding the names "rook-ceph-block" and "rook-cephfs", limiting the e2e tests to drenv environment. Add a Name key to each PVCSpec entry, eliminating the code to create a suffix. We use the name to crate the name of the test. Part-of: #1635 Signed-off-by: Nir Soffer <[email protected]>
raghavendra-talur
pushed a commit
that referenced
this issue
Dec 12, 2024
We checked if a deployer supports a workload by checking the hardcoded string "Deploy-cephfs". This wrong it 2 ways, assuming that we use the "Deploy" prefix, and assuming that the storage name is "cephfs". Fix by adding "unsupportedDeployers" lists to PVCSpec. The cephfs default configuration include the "disapp" as unsupported deployer. Move the supported check from the deployer to the workload, since the deployer has no state and it cannot tell if a workload is supported. To make it easier to filter deployers, names are now lower case. We anyway use lower case for test names. With this change, we can use any PVCSpec name, and we can keep multiple configurations running all of some the tests. Fixes: #1635 Signed-off-by: Nir Soffer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
test
Testing related issue
The e2e framework uses a list of storage class names and access modes:
Based on this list, we generate test names:
This works only for drenv environment. For openshift environment the storage class names are different so the returned suffix with be the actual storage class name, which is way to long to use as a test name or for using resource names.
Even worse, there is code hidden deployers/discoveredapps.go, filtering out cephfs workloads for discovered apps, based on the suffix:
This will not match for when using real cluster storage classes, trying to run unsupported combination.
Possible fix
Move the logic to the config:
Blocks #1625
The text was updated successfully, but these errors were encountered: