-
-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR #3 - Firmware build version with short git hash suffix #587
Merged
Ralim
merged 12 commits into
Ralim:master
from
GeminiServer:PR-#3-Version-rule-and-format
Mar 19, 2020
+6,732
−5,755
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0461fd0
Unified the default configuration/setting values and parameters into …
GeminiServer 2d0e072
Tip temp change short and long press and reverse +- button to ui conf…
GeminiServer 2e67da0
New - Version rule and format.
GeminiServer 3fac547
revert reformatings
GeminiServer 1f20bf9
fixed default values and settings
GeminiServer 7f844d9
Merge branch 'PR-#1-Configuration' into PR-#2-Temp-Steps-and-revert-b…
GeminiServer 9d98530
Merge branch 'PR-#2-Temp-Steps-and-revert-buttons' into PR-#3-Version…
GeminiServer 04be8fd
Fixed - configuration include header
GeminiServer 070f909
Merge branch 'PR-#1-Configuration' into PR-#2-Temp-Steps-and-revert-b…
GeminiServer 9762beb
Merge branch 'PR-#2-Temp-Steps-and-revert-buttons' into PR-#3-Version…
GeminiServer 4aabf77
Removed BUILD_VERSION from python translation
GeminiServer a5ec2bc
Let's try in in python translate script directly, to keep support ci …
GeminiServer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance you feel like swapping out the REL/Beta/Alpha + build numbers to instead be major.minor.
git short hash
To make it clear where it came from ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GeminiServer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea to use the git short hash instead a build number.