Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RToS Update #2091

Merged
merged 7 commits into from
Mar 1, 2025
Merged

Fix RToS Update #2091

merged 7 commits into from
Mar 1, 2025

Conversation

Ralim
Copy link
Owner

@Ralim Ralim commented Mar 1, 2025

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • [] There are no breaking changes
  • What kind of change does this PR introduce?

Closes #2090
Closes #2089

Fixes task max priorities due to update to rtos related code earlier.

  • What is the current behavior?
  • Other information:

Tested on

  • TS80
  • MHP30
  • TS80P
  • S60P
  • PinecilV2

@Ralim Ralim merged commit 08002e0 into dev Mar 1, 2025
36 checks passed
@Ralim Ralim deleted the update-fix branch March 1, 2025 21:56
Copy link
Collaborator

@ia ia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @Ralim.

I was catching up with the recent changes, and now I'm just very curious about Makefile update, so I have a couple of questions (only for my own better understanding).

I will be very thankful, if you will find a bit of time to explain these updates to me, thanks in advance:

@@ -425,6 +425,7 @@ CHECKOPTIONS=-Wtrigraphs \
-Wmissing-field-initializers \
-Wshadow \
-Wno-unused-parameter \
-Wno-undef \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try to find some time to make a build without this option to check myself, but what exact warnings you would like to hide with this flag?

I understand how annoying some of the warnings may be, but I personally prefer better to see them and hoping to deal with them some time later, than hiding completely.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FreeRTOS added two #if checks around the ticks count but it also breaks if you define both (even if one is 1 and one is 0). But this warning trips because one of them isn't defined.

Copy link
Owner Author

@Ralim Ralim Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Id love a better solution to this btw, just didnt find one, and didn't appreciate the screen of warnings 🙃 . One option would be to only add this when compiling things that include the freertos headers.. but thats most of the binary :(

@@ -454,6 +455,7 @@ CFLAGS=$(DEV_CFLAGS) \
-D${COMPILER} \
-MMD \
-std=gnu11 \
-g3 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked the sizes of output binaries closely yet, and considering there is a process of stripping/converting firmware files, this shouldn't hurt, I guess, but why exactly you did enable debug symbols?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really only affects the .elf files, so that I get proper symbols when debugging.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the information. Just one more thing:

I get proper symbols when debugging.

Do you just load produced .elf files via gdb-arm-none-eabi/gdb-multiarch and debug them "statically"? Or do you have some additional special setup to get dynamic stepping? I'm curious, because I have that question anyway for a long time, but always forgot to ask.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I load them onto the device over SWD/JTAG (depending on the device). Using usual openocd and gdb process for embedded, and then step through it all. Sometimes I'll use the segger tools (as I have a JLink) but not often.

@paulfertser
Copy link
Contributor

paulfertser commented Mar 4, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootloop with TS101 and v2.23-rc2 Black screen after installing v2.23-rc2 on Sequre S60P and T55
3 participants