Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Overall French Translations #2085

Merged
merged 6 commits into from
Feb 25, 2025
Merged

Updated Overall French Translations #2085

merged 6 commits into from
Feb 25, 2025

Conversation

JustLeska
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes

  • What kind of change does this PR introduce?
    Update of the translations and warning messages in the user interface, along with improved clarity of certain terms.
    Translated new features that weren't translated yet.

  • What is the current behavior?
    The user interface messages use less precise terms and less optimized translations. Some text isn't even translated yet.

  • What is the new behavior (if this is a feature change)?

  • Corrected several translation terms.
  • Improved warning messages for better clarity, such as "LOW VOLTAGE" and "Tip Shorted".
  • Updated text strings to better match their usage contexts in French, such as "Power Source" and "Default Mode".
  • Most of the text is translated.
  • Other information:
  • No major functional changes, only text updates to enhance user experience.

@discip
Copy link
Collaborator

discip commented Feb 24, 2025

@JustLeska
Have you tested these changes locally?
If not yet, please do so since there is at least one line that seems to be problematic.

@JustLeska
Copy link
Contributor Author

@JustLeska Have you tested these changes locally? If not yet, please do so since there is at least one line that seems to be problematic.

I have built and tested it on my Pincecil V2 (I don't have the other soldering irons to test). However, it seems to be working fine on my Pinecil.

@discip
added missing options
55e497f 
For some reason the following options were missing:
* Cool Down Blink
* Reverse Temp Change Buttons
@discip
Update translation_FR.json
7a2082d
@discip
Update translation_FR.json
b1e74e7
@discip discip enabled auto-merge (squash) February 25, 2025 16:05
@discip
Copy link
Collaborator

discip commented Feb 25, 2025

@JustLeska
Would you mind having a look one last time before this gets merged in?

@discip discip merged commit 40655a9 into Ralim:dev Feb 25, 2025
18 checks passed
JustLeska added a commit to JustLeska/IronOS that referenced this pull request Feb 25, 2025
@JustLeska
Revert "Updated Overall French Translations (Ralim#2085)"
4bf3509 
This reverts commit 40655a9.
@JustLeska
Copy link
Contributor Author

JustLeska commented Feb 25, 2025 •
edited
Loading

@discip
The 👍 reaction was to let you know I was getting on it, I didn’t expect the PR to be merged just yet, so I’ve finished the review and made a few tweaks to improve the text fit better. If there’s anything else you need. Should I revert the merge and apply the changes, or would you prefer I create a new PR with the modifications?

Sorry about that... I'm very new to doing PRs, I'm still learning...😅

@discip
Copy link
Collaborator

discip commented Feb 25, 2025

@JustLeska
Oh, sorry I actually misinterpreted your reaction.
Please just open another PR.

@JustLeska JustLeska mentioned this pull request Feb 25, 2025
Merged
2 tasks
@ia ia added the Translations Linguas, i18n & l10. label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@discip discip discip approved these changes

Assignees
No one assigned
Labels
Translations Linguas, i18n & l10.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JustLeska @discip @ia