Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Custom tip type selection #1977

Merged
merged 18 commits into from
Nov 1, 2024
Merged

[WIP] Custom tip type selection #1977

merged 18 commits into from
Nov 1, 2024

Conversation

Ralim
Copy link
Owner

@Ralim Ralim commented Sep 22, 2024

  • Please check if the PR fulfills these requirements
  • [] The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?

Adding support for manual tip type selections on devices.
Needs testing on devices a bit more still, but should mostly work (I think)

  • What is the current behaviour?
  • What is the new behaviour (if this is a feature change)?

  • Other information:

@Ralim
Copy link
Owner Author

Ralim commented Sep 25, 2024

This should be good to go now I think, will need to do a spot test on older units

Documentation/HallSensor.md Outdated Show resolved Hide resolved
Documentation/HallSensor.md Outdated Show resolved Hide resolved
Documentation/Hardware.md Outdated Show resolved Hide resolved
@Ralim
Copy link
Owner Author

Ralim commented Oct 16, 2024

@discip Wanted to check if you spotted anything else in the text that should be changed?

Copy link
Collaborator

@discip discip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ralim
After a cursory look through it, I think it should be good to go.

Documentation/Hardware.md Outdated Show resolved Hide resolved
@Ralim Ralim merged commit a0a779f into dev Nov 1, 2024
36 checks passed
@Ralim Ralim deleted the testing branch November 1, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants