Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translations adapted #1976

Merged
merged 38 commits into from
Oct 29, 2024
Merged

translations adapted #1976

merged 38 commits into from
Oct 29, 2024

Conversation

Staubgeborener
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?
  • correct indention in all translations
  • add "displayText": "HallSensor\nSleepTime" for for many translations
  • What is the current behavior?
  • wrong indentions in all translations in specific are around "displayText": "HallSensor\nSleepTime"
  • missing "displayText": "HallSensor\nSleepTime" translation
  • What is the new behavior (if this is a feature change)?
    see What kind of change does this PR introduce?

  • Other information:

@discip discip enabled auto-merge September 19, 2024 09:56
auto-merge was automatically disabled September 20, 2024 06:55

Head branch was pushed to by a user without write access

@discip discip enabled auto-merge September 20, 2024 07:33
auto-merge was automatically disabled September 20, 2024 08:22

Head branch was pushed to by a user without write access

@discip
Copy link
Collaborator

discip commented Oct 4, 2024

@Staubgeborener
Sorry, I somehow lost track of this.
Do you have any idea what the problem could be other than your recent attempts to fix the compilation errors?
I tried to look for a possible cause, but unfortunately I have absolutely no clue what to blame.

@Ralim
Maybe you are able to spot the cause. 😊

@Staubgeborener
Copy link
Contributor Author

@Staubgeborener Sorry, I somehow lost track of this. Do you have any idea what the problem could be other than your recent attempts to fix the compilation errors? I tried to look for a possible cause, but unfortunately I have absolutely no clue what to blame.

@Ralim Maybe you are able to spot the cause. 😊

  File "/__w/IronOS/IronOS/source/../Translations/make_translation.py", line 532, in get_font_map_per_font
    raise KeyError(f"Symbol |{sym}| is missing in large font set")
KeyError: 'Symbol |ợ| is missing in large font set'
make: *** [Makefile:548: Core/Gen/Translation.VI.cpp] Error 1
make: *** Waiting for unfinished jobs....
Error: Process completed with exit code 2.

It seems that certain special characters that occur in some languages cannot be interpreted correctly (maybe this function).

@Ralim
Copy link
Owner

Ralim commented Oct 6, 2024

Hia,

KeyError: 'Symbol |ợ| is missing in large font set'
This is thrown deliberately if we do not have that character in our font table.
This is to prevent Symbols we dont have being used (unless they are added).
Symbols are defined here https://github.com/Ralim/IronOS/blob/fe6bf7f1f04d2d958a2acb66eeb0bca4701d6fc1/Translations/font_tables.py

@discip discip merged commit 150aa0d into Ralim:dev Oct 29, 2024
18 checks passed
@discip
Copy link
Collaborator

discip commented Oct 29, 2024

I ended up just leaving the original English sentence as it was because I would definitely have mixed something up, as there are a lot more letters that aren't supported.
The original translator knew which letter to replace with which other. I absolutely don't! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants