-
-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a sleep timeout setting for hall sensor #1969
Conversation
Will try and fix issues in CI. |
source/Core/Inc/Settings.h
Outdated
ProfilePhase5Temp = 50, // Temperature to target for the end of phase 5 | ||
ProfilePhase5Duration = 51, // Target duration for phase 5 | ||
ProfileCooldownSpeed = 52, // Maximum allowed cooldown speed in degrees per second | ||
HallEffectSleepTime = 29, // Seconds timeout to sleep when hall effect over threshold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this has to go at the end, these index's are used for setting migration between reflash so new settings need to be appended :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fantastic, please append the setting to the end of the list to ensure that settings migrate for users but otherwise looks great 👍🏼
I see that CI failure is due to all but one language files missing the new line, should I add the english text in all languages? |
Yeah you have to add something to all files, I normally add English as the filler by default (I only know one language :( ) |
Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems good to me. Have you tested it ?
Yes, also measured times which seemed accurate. |
Fantastic, just wanted to check as I dont have my unit next to me. |
Head branch was pushed to by a user without write access
Would you be able to approve CI run again? Sorry for not checking this earlier, didn't know what tests were relevant (maybe I should send a PR to the development page with info about that also?). |
Yeah I'll let it run whenever I get the notification; this trap only happens for first PR to the repo. Documentation updates are always loved 🤣 |
Neato, everything seems to pass now. Thank you very much for the speedy review btw :) |
Thank you for getting this into a PR so soon from filing the issue 🙇🏼 Reviewing and merging PR's is always easier than doing the work. |
What is the point after the unit of measurement for? |
Do you mean the s (seconds) or do you mean the .? the . has already been there and is a scroll progress bar in the list. |
Whops, yes, you're right. It's just the scroll bar 😅. |
^ I'm not sure, I changed the order of the settings inSettings.h
andSettings.c
, I'm not sure if this breaks anything. I did get my settings reset after the flash (with aCertain settings changed!
message). Please let me know if I should just add it to the end of the list or something, which would then hopefully make it non-breaking.It adds an option to sleep when the soldering iron is placed on a stand, with the amount to sleep configurable. Default is 1 second, which was the behavior before. It can be set up to 60 seconds, with 5 second increments.
I had opened a feature request here: #1968
(Implements #1968)
What is the current behavior?
With a hall effect sensor configured, the iron goes to sleep after 1 second after going above threshold.
What is the new behavior (if this is a feature change)?
This amount can be configured.
Other information:
Fitting the text is hard, I had to put it without spaces in English. Good luck to translators.