Add enum for modes of locking buttons #1955
Conversation
source/Core/Inc/Settings.h
Outdated
| typedef enum { | ||
| DISABLED = 0, // Locking buttons is disabled | ||
| BOOST = 1, // Locking buttons for Boost mode only | ||
| FULL = 2, // Locking buttons fully |
There was a problem hiding this comment.
| FULL = 2, // Locking buttons fully | |
| ALL = 2, // Locking all buttons |
There was a problem hiding this comment.
Are you sure that this will be better? I just tried to keep the code as coherent as possible in accordance with the other parts including description itself and documentation to avoid any unnecessary ambiguity and not to puzzle anyone without extra need in the future.
We could change all the other descriptions after the suggestion though, but it would lead to the need of updating all translation files as well, which is - in my very humble opinion - total overkill.
TL;DR: this option-related value is notated as full in the description and in the documentation so why it should be all in the code exactly? Just curious.
There was a problem hiding this comment.
It can be full, mostly just wanted to not have "Locking buttons fully" as it feels a very clunky description, and we are not length limited here like we are in the description.
There was a problem hiding this comment.
Aha, ok. I think I got it... Let me prepare a slightly updated solution then.
| @@ -113,7 +113,7 @@ typedef enum { | |||
| typedef enum { | |||
| DISABLED = 0, // Locking buttons is disabled | |||
| BOOST = 1, // Locking buttons for Boost mode only | |||
| FULL = 2, // Locking buttons fully | |||
| FULL = 2, // Locking buttons for Boost mode AND for Soldering mode | |||
|
Is there a missing delay between lock and unlock? If I hold both buttons, it very quickly toggles between locked and unlocked. |
|
@neon12345 Best to open a new issue for this as this PR has already been merged and is not directly related. |
What kind of change does this PR introduce?
Add
enumfor modes of locking buttons in Settings.What is the current behavior?
Constants are used for
SettingsOptions::LockingMode.What is the new behavior (if this is a feature change)?
Use self-documented
enumvalues forSettingsOptions::LockingMode.Other information:
With this tiny refactoring now all the constants for settings should be ironed out ;)