Implement OLED::drawUnavailableIcon() to simplify duplicated calls #1947
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Implement
OLED::drawUnavailableIcon()
to simplify duplicated calls.What is the current behavior?
Multiple calls of
OLED::drawArea(OLED_WIDTH - 16 - 2, 0, 16, 16, UnavailableIcon)
insettingsGUI.cpp
with magic constants.What is the new behavior (if this is a feature change)?
Simply call
OLED::drawUnavailableIcon()
to drawUnavailableIcon
which helps:Other information:
Check this another one small trivial refactoring out. ;)
I'm not sure about the necessity of
inline
but I just wanted to give compilers explicit directive to make calls in place to make sure.