Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: add S60P to MODELS #1897

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Makefile: add S60P to MODELS #1897

merged 1 commit into from
Mar 28, 2024

Conversation

ia
Copy link
Collaborator

@ia ia commented Mar 26, 2024

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?
    Tiny update for top-level Makefile.

  • What is the current behavior?
    S60P is officially supported now but it's missing in top-level Makefile.

  • What is the new behavior (if this is a feature change)?
    Now S60P is added to top-level Makefile so S60P target can be used right from the root directory.

  • Other information:
    By the way, much appreciated and deeply honored for collaborator status in this incredible project, being right next to wonderful and amazing people.

P.S. I took some liberty to update and unify labels a bit, hope no one's mind.

@ia ia added the Build System make/bash/python, github CI/CD & pals. label Mar 26, 2024
@ia ia self-assigned this Mar 26, 2024
@ia ia requested a review from Ralim March 26, 2024 09:58
@Ralim
Copy link
Owner

Ralim commented Mar 28, 2024

Ah dang, apologies for missing it

By the way, much appreciated and deeply honored for collaborator status in this incredible project, being right next to wonderful and amazing people.

All good; you have stuck around long enough trusted and welcome. Please don't go power crazy I prefer to review large code changes, but improving docs/github setup/translations/issues etc just-go-for-it.

@Ralim Ralim merged commit d98654b into Ralim:dev Mar 28, 2024
17 checks passed
@ia
Copy link
Collaborator Author

ia commented Mar 28, 2024

you have stuck around long enough trusted and welcome.

Thank you, really. 🙏
At first I was just looking for the projects & contributions to boost some of my skills, but definitely have found way much more than just that.

Please don't go power crazy

I value my reputation (or karma or decency or whatever some other people may call it) but thanks for the reminder. Although if it's not some horrible mistake in one of my scripts to interact with git(hub) for commit/merge automagically, we shouldn't worry. ;)

I prefer to review large code changes

Of course! And that's how it should be, so no problem with that at all.

but improving docs/github setup/translations/issues etc just-go-for-it.

Aye-aye, Captn! And what about actualization and maybe even closing long ago opened but stalled issues? Can I do that sometimes maybe? By now you probably noticed that I just prefer to keep the tracker uncluttered.

Oh, and one more thing... just for your information: actually I don't have permissions to commit/merge right to the dev. As far as I understand this branch is configured as protected by GitHub project settings so it seems every merge commit must be approved through pull request form: I didn't want to bother you with this pull request so I actually did take some courage and did try to push it but I got something like "repository write protection" error. But I think in this way it's even better - less chances to bloop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build System make/bash/python, github CI/CD & pals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants