Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dutch translations #1863

Merged
merged 12 commits into from
Jan 8, 2024
Merged

Dutch translations #1863

merged 12 commits into from
Jan 8, 2024

Conversation

ColoMAX
Copy link
Contributor

@ColoMAX ColoMAX commented Dec 28, 2023

  • Improved translations for NL and NL_BE
  • Fixed some text after testing
  • Improved translation for NL and NL V3_BE
  • Fixed some wrong spelling and totally wrong translations.
  • Added some missing translations.
  • Modified single char option in menu.
  • Not tested on display.

continues & resolves #1830

DjedenOfficial and others added 9 commits October 22, 2023 20:31
It works after testing. However I fixed some minor issues. A second test is required.
Fully translated NL and NL_BE to dutch.
Added some missing translations.
Modified single char option in menu.
Not tested on display.
@discip discip enabled auto-merge December 29, 2023 00:07
@discip
Copy link
Collaborator

discip commented Dec 29, 2023

@ColoMAX
Thank you for this PR.
Would you please try the compiled version and report back in order to get this merged?

thanks in advance
kind regards

auto-merge was automatically disabled December 29, 2023 10:33

Head branch was pushed to by a user without write access

@ColoMAX
Copy link
Contributor Author

ColoMAX commented Dec 29, 2023

Trying it on the Pinecilv2, but the settings QCMaxVoltage till PDVpdo are not getting displayed, also Bluetooth the setting. But this is also true for the EN version, so this is more likely a bug to do with the custom boot logo I previously installed, and does not seem to go away with subsequent firmware uploads.

I used the newest blisp from soure for all uploads.

@discip discip enabled auto-merge December 29, 2023 13:45
@discip
Copy link
Collaborator

discip commented Dec 29, 2023

Try the following:

  1. Flash the Boot-Logo you want (it has to be *.dfu though) logos for Pinecil-V2:

    sudo blisp write -c bl70x --reset IronOS.gif.dfu
    
  2. Flash IronOS firmware for Pinecil-V2:

    sudo blisp write -c bl70x --reset Pinecilv2_multi_compressed_European.bin
    

On my Pinecil-V2 this works as expected.

@ColoMAX
Copy link
Contributor Author

ColoMAX commented Jan 2, 2024

Try the following:

1. Flash the Boot-Logo you want _(**it has to be `*.dfu` though**)_ [logos for Pinecil-V2](https://github.com/Ralim/IronOS-Meta/releases/download/latest/pinecilv2.zip):
   ```
   sudo blisp write -c bl70x --reset IronOS.gif.dfu
   ```

2. Flash IronOS [firmware for Pinecil-V2](https://github.com/Ralim/IronOS/actions/runs/7343147381/artifacts/1137185514):
   ```
   sudo blisp write -c bl70x --reset Pinecilv2_multi_compressed_European.bin
   ```

On my Pinecil-V2 this works as expected.

This indeed fixes the problem with the V2.22 c308fe8 release files.
End of the week, will try again with the PR version.

@discip
Copy link
Collaborator

discip commented Jan 3, 2024

@ColoMAX
Nice!
So is this good to finally merge it in? 😊

@ColoMAX
Copy link
Contributor Author

ColoMAX commented Jan 8, 2024

@ColoMAX Nice! So is this good to finally merge it in? 😊

Yes, although I have found that the Ralim/dev (166cf93) has the same problem with multiple languages not displaying all settings titles. Whilst the latest release does work correctly.

@discip discip merged commit 7d9bbbc into Ralim:dev Jan 8, 2024
@discip
Copy link
Collaborator

discip commented Jan 8, 2024

Please try the latest build:
https://github.com/Ralim/IronOS/actions/runs/7451884972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants