Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UploadV4 metadata workaround #1855

Merged
merged 38 commits into from
Dec 26, 2023
Merged

UploadV4 metadata workaround #1855

Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
8105702
chore(deps): bump actions/upload-artifact from 3 to 4
dependabot[bot] Dec 18, 2023
8504940
push.yml: split metadata artifacts into two separated packages since …
ia Dec 19, 2023
769b0ed
push.yml: add metadata per model artifact since now it's error by des…
ia Dec 19, 2023
33c2d28
push.yml: testing proposed by github solution for actions:#472
ia Dec 19, 2023
d530460
push.yml: "fixing" upload as github team suggested
ia Dec 19, 2023
4fe3fa8
push.yml: rename upload metadata step to unify build steps naming pat…
ia Dec 19, 2023
e638f8d
push.yml: upload_metadata: add if-no-files-found: error directive sin…
ia Dec 19, 2023
d1ef5d1
Merge changes from dev
ia Dec 19, 2023
92fb7c1
Merge changes from dev
ia Dec 19, 2023
70b0300
push.yml: giving a second chance for cache save/restore actions
ia Dec 19, 2023
05fd7fe
push.yml: remove unsupported name field from cache actions
ia Dec 19, 2023
5b16e8d
push.yml: add tar to deps so cache action can collect cached files on…
ia Dec 19, 2023
dd80f52
push.yml: try to retrieve cache by key properly
ia Dec 19, 2023
c05b241
push.yml: try to retrieve cache by key properly
ia Dec 19, 2023
ffe5e71
push.yml: remove wildcards from keys
ia Dec 19, 2023
3609c6c
push.yml: try retrieve cache by explicit name
ia Dec 19, 2023
0513cf2
push.yml: trying with enableCrossOsArchive == true
ia Dec 19, 2023
904e134
push.yml: revert changes back from cache save/restore to actions down…
ia Dec 19, 2023
401d7af
push.yml: set retention-days == 1 and testing dot file name hoping it…
ia Dec 19, 2023
ab608c0
push.yml: upload_metadata - download jsons: fix pattern for testing
ia Dec 19, 2023
a296073
push.yml: adding 3rd party step for testing to delete created artifacts
ia Dec 19, 2023
5879456
push.yml: trying to fix syntax in 3rd party step
ia Dec 19, 2023
a290735
push.yml: revert changes to working workaround but keep retention-day…
ia Dec 19, 2023
1dbbd24
push.yml: upload_metadata: download prebuilt artifacts, generate json…
ia Dec 20, 2023
ba864f8
push.yml: upload_metadata: trying to fix pattern for artifacts [WiP]
ia Dec 20, 2023
87d7c86
push.yml: upload_metadata: remove matrix since it doesn't work [WiP]
ia Dec 20, 2023
5452a10
push.yml: upload_metadata: remove pattern to download all prebuilt ar…
ia Dec 20, 2023
57e346a
push.yml: add every json to every model of artifact
ia Dec 20, 2023
8b8bb95
push.yml: remove uploading/reuploading individual json files as zips
ia Dec 20, 2023
ed3ac20
push.yml: pushing to see which error will be at this time...
ia Dec 20, 2023
490e335
ci
ia Dec 20, 2023
f3978e0
Revert "push.yml: pushing to see which error will be at this time..."
ia Dec 20, 2023
2927780
push.yml: revert manually due to accidential commit from different br…
ia Dec 20, 2023
6970a46
Merge from dev to sync changes & solving conflict changes in push.yml…
ia Dec 26, 2023
693771d
Remove the image of my frustration with github checkout update
ia Dec 26, 2023
d99e5f2
Merge branch 'dev' into upload-artifact-4_metadata-fix
Ralim Dec 26, 2023
650013a
Sync the latest changes from dev
ia Dec 26, 2023
366d76c
Merge branch 'upload-artifact-4_metadata-fix' of ssh.github.com:ia/Ir…
ia Dec 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 27 additions & 15 deletions .github/workflows/push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,26 +45,22 @@ jobs:
- name: Copy license files
run: cp LICENSE scripts/LICENSE_RELEASE.md source/Hexfile/

- name: Generate json index file
run: ./source/metadata.py ${{ matrix.model }}.json

- name: Archive ${{ matrix.model }} artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.model }}
path: |
source/Hexfile/${{ matrix.model }}_*.hex
source/Hexfile/${{ matrix.model }}_*.dfu
source/Hexfile/${{ matrix.model }}_*.bin
source/Hexfile/${{ matrix.model }}.json
source/Hexfile/LICENSE
source/Hexfile/LICENSE_RELEASE.md
if-no-files-found: error

- name: Generate json index file
run: ./source/metadata.py ${{ matrix.model }}.json

- name: Archive ${{ matrix.model }} index file
uses: actions/upload-artifact@v3
with:
name: metadata
path: source/Hexfile/${{ matrix.model }}.json

build_multi-lang:
runs-on: ubuntu-22.04
Expand Down Expand Up @@ -97,26 +93,42 @@ jobs:
- name: Copy license files
run: cp LICENSE scripts/LICENSE_RELEASE.md source/Hexfile/

- name: Generate json index file
run: ./source/metadata.py ${{ matrix.model }}_multi-lang.json

- name: Archive ${{ matrix.model }} artifacts
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ matrix.model }}_multi-lang
path: |
source/Hexfile/${{ matrix.model }}_*.hex
source/Hexfile/${{ matrix.model }}_*.dfu
source/Hexfile/${{ matrix.model }}_*.bin
source/Hexfile/${{ matrix.model }}_multi-lang.json
source/Hexfile/LICENSE
source/Hexfile/LICENSE_RELEASE.md
if-no-files-found: error

- name: Generate json index file
run: ./source/metadata.py ${{ matrix.model }}_multi-lang.json

- name: Archive ${{ matrix.model }} index file
uses: actions/upload-artifact@v3
upload_metadata:
needs: [build, build_multi-lang]
runs-on: ubuntu-20.04

steps:
- name: Download all prebuilts
uses: actions/download-artifact@v4
with:
path: source/Hexfile/
merge-multiple: true
- run: ls -R source/Hexfile

- name: Upload JSONs in bulk as metadata
uses: actions/upload-artifact@v4
with:
name: metadata
path: source/Hexfile/${{ matrix.model }}_multi-lang.json
path: source/Hexfile/*.json
if-no-files-found: error


tests:
runs-on: ubuntu-22.04
Expand Down