graphics for S60/P & TS101 #1819
Conversation
|
@Ralim Hope you like it. |
|
Amazing work, suppppppppeeerrrr appreciate it. Haven't had a chance to test on hardware yet but when I get some downtime I will do some quick patching to get some of this in place asap 🤞 Thank you so much for this ❤️ |
Pull request was converted to draft
|
I somehow managed to compile your branch for my TS101 by rebasing your branch on the dev branch, but the icons are not being displayed correctly. I guess this is because support for bigger displays has not been added yet?
|
|
Hi! |
As you may have noticed in your photo only a portion of the OLED but the individual graphics are intended for the whole screen. |
|
On my new TS101 I have firmware V2.04. |
|
Besides the graphics what else is needed? @Ralim |
|
This will be pulled in via the branch for splitting out rendering for different screen sizes. I'm slowly working on it as life allows me to. |
okay I'll have a look in a bit and see if I can help with that, also for the standardized power interface do you want to include all currently supported usb protocols so QC and USB-PD or just USB-PD? |
|
Once I finish splitting all the render/* functions out (in a day or two) I'll start a draft PR to track it. I only intend to implement PD for all devices going forward if I get any choice in it. QC is a dead standard and its a shit-show for compatibility as well. Much prefer only focusing on standards that are open and properly standardised. |
|
@Ralim |
I've now pulled these into #1883, and will slowly be working over there to update all the drawing commands to draw the right size / location |
|
@Ralim Could you please help finding the cause, why this doesn't compile for the thanks in advance |
Hello. It seems there is no declaration of Pre-processor goes here for Basically, since support for Probably for fix you should make this line to look something like this: Hope it will help. |
|
Thank you very much for the effort you put into describing the issue so precisely!
You are absolutely right. That's the line I missed. 🤦♂️ |
I just was happy to help with everything I can, as always. Glad it worked. :) |
|
This was implemented in #1888. |
* Create README.md * Move to new folder * Migrating * Migrate Remainder * format fix (all but one) (#1889) * Update USBPDDebug_FS2711.cpp * Delete PrintVoltage.cpp * Copy in 128x32 template * Mask drawing for 96x16 * Import #1819 * Update Font.h * Homescreen * Update draw_homescreen_detailed.cpp * Fix oled normal draw for variable height * Update OLED.cpp * Draw settings icons * Update draw_homescreen_simplified.cpp * Update draw_power_source_icon.cpp * Fixup oled drawing for fill area * Update the region fill for mixed heights * Fix newline height * FIXUP! Draw icons in settings menu at correct size * Fix scrollbar * Update settingsGUI.cpp * S60(P) Disable auto display rotation * On tall oled, scroll in 2 line increments * Bugfix transition L<->R @discip I take it back, there was a bug :) * Draw every other one on transitions * . * cleanup * Bootup logo: Draw in centre * Update OLED.hpp --------- Co-authored-by: discip <[email protected]>
@Ralim
Here you go. 😀
Tried to implement all the necessary graphics for
S60/P&TS101.I know this will not work until you do all the necessities around it.
At least I hope the way I tried to implement this makes any sense. 😅
Not every graphic is pretty yet, but at least it should be testable.
Please let me know what you think.