Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify commands for jobs in push.yml #1761

Merged
merged 7 commits into from
Jul 28, 2023
Merged

Simplify commands for jobs in push.yml #1761

merged 7 commits into from
Jul 28, 2023

Conversation

ia
Copy link
Collaborator

@ia ia commented Jul 27, 2023

  • Please check if the PR fulfills these requirements
  • The changes have been tested locally
  • There are no breaking changes
  • What kind of change does this PR introduce?
    Simplifying commands in push.yml.

  • What is the current behavior?
    push.yml may contain extra commands.

  • What is the new behavior (if this is a feature change)?
    Now since the permissions for script files are fixed and make-based build system is almost fully location-agnostic we can call some commands on github CI in a shorter way.

  • Other information:
    Tested locally & successfully all the commands from push.yml but let's see what github CI will tell about that. I will check & double check the logs & artifacts to make sure that all the builds steps are being performed as expected after creating PR.

@ia
Copy link
Collaborator Author

ia commented Jul 28, 2023

I did check logs for all steps and they seem fine. I even downloaded some artifacts to make sure that the files where they supposed to be.

Just had one strange error which I couldn't reproduce - right after re-run it was gone. So it seems like some glitch in Link Time Optimization of GCC. 🤷‍♂️

@Ralim Ralim enabled auto-merge (squash) July 28, 2023 09:43
@Ralim Ralim merged commit 55d36c9 into Ralim:dev Jul 28, 2023
@ia ia deleted the push-cmds branch July 28, 2023 10:16
@ia
Copy link
Collaborator Author

ia commented Jul 28, 2023

I did check logs for all steps and they seem fine. I even downloaded some artifacts to make sure that the files where they supposed to be.

Just had one strange error which I couldn't reproduce - right after re-run it was gone. So it seems like some glitch in Link Time Optimization of GCC. man_shrugging

It seems this issue is coming back sometimes. But I have no idea how it could be related to these changes, directly or indirectly. If I would have been forced to give any explanation, my very first thought is that maybe somehow make/parallel building involved: since lto1 can't read a section from file, not file itself, maybe file is not fully generated yet by the moment when lto1 tries to read section for optimization. 🤷‍♂️

Anyway, should we address this issue in anyway somehow considering that with the next re-run it probably will disappear? Should I let you know if I will be able to reproduce it locally somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants